Skip to content

Commit 5ae36c5

Browse files
authored
Fix issue when reconnecting after connected via REST (#127)
* Fix issue when reconnecting after connected via REST * Minor cleanup
1 parent f2517e3 commit 5ae36c5

File tree

2 files changed

+59
-5
lines changed

2 files changed

+59
-5
lines changed
Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
/*
2+
* Copyright (c) 2025 Oracle and/or its affiliates. All rights reserved.
3+
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4+
*
5+
* This code is free software; you can redistribute it and/or modify it
6+
* under the terms of the GNU General Public License version 2 only, as
7+
* published by the Free Software Foundation. Oracle designates this
8+
* particular file as subject to the "Classpath" exception as provided
9+
* by Oracle in the LICENSE file that accompanied this code.
10+
*
11+
* This code is distributed in the hope that it will be useful, but WITHOUT
12+
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
13+
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
14+
* version 2 for more details (a copy is included in the LICENSE file that
15+
* accompanied this code).
16+
*
17+
* You should have received a copy of the GNU General Public License version
18+
* 2 along with this work; if not, write to the Free Software Foundation,
19+
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
20+
*
21+
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
22+
* or visit www.oracle.com if you need additional information or have any
23+
* questions.
24+
*/
25+
package com.oracle.coherence.plugin.visualvm;
26+
27+
import org.graalvm.visualvm.application.Application;
28+
29+
import static org.graalvm.visualvm.host.Host.UNKNOWN_HOST;
30+
31+
/**
32+
* MockApplication is a class used to register a REST connection to fix
33+
* issue when unregistering application..
34+
*/
35+
public class MockApplication extends Application
36+
{
37+
// ---- constructors ----------------------------------------------------
38+
39+
/**
40+
* Constructs a new MockApplication instance.
41+
*
42+
* @param id the unique identifier for this application
43+
*/
44+
public MockApplication(String id)
45+
{
46+
super(UNKNOWN_HOST, id);
47+
}
48+
}

coherence-visualvm-plugin/src/main/java/com/oracle/coherence/plugin/visualvm/VisualVMView.java

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2020, 2022 Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2020, 2025 Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -58,11 +58,9 @@
5858
import java.awt.event.ActionEvent;
5959
import java.awt.event.ActionListener;
6060

61-
import java.util.LinkedHashSet;
62-
import java.util.List;
63-
import java.util.Map;
64-
import java.util.Set;
61+
import java.util.*;
6562
import java.util.concurrent.ConcurrentHashMap;
63+
import java.util.concurrent.atomic.AtomicInteger;
6664
import java.util.logging.Level;
6765
import java.util.logging.Logger;
6866

@@ -167,6 +165,12 @@ protected DataViewComponent createComponent()
167165
addModelForApplication(m_application, model);
168166
}
169167

168+
if (m_application == null)
169+
{
170+
// this is called from REST, so create a dummy application, so the visual VM Model gets cleaned up
171+
m_application = new MockApplication(String.valueOf(f_counter.incrementAndGet()));
172+
}
173+
170174
boolean fClusterSnapshotEnabled = com.oracle.coherence.plugin.visualvm.GlobalPreferences
171175
.sharedInstance().isClusterSnapshotEnabled();
172176

@@ -516,4 +520,6 @@ public static void addModelForApplication(Application application, VisualVMModel
516520
* Set of panels to refresh and update.
517521
*/
518522
private final Set<AbstractCoherencePanel> f_setPanels = new LinkedHashSet<>();
523+
524+
private static final AtomicInteger f_counter = new AtomicInteger(0);
519525
}

0 commit comments

Comments
 (0)