Skip to content

Commit 80f5960

Browse files
authored
Add deprecation comments to CRD fields that are deprecated in the underlying APIs (#710)
1 parent 9d77d08 commit 80f5960

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

api/v1/coherence_types.go

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1512,15 +1512,23 @@ type ServiceMonitorSpec struct {
15121512
// +optional
15131513
TLSConfig *monitoringv1.TLSConfig `json:"tlsConfig,omitempty"`
15141514
// File to read bearer token for scraping targets.
1515-
// See https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api-reference/api.md#endpoint
1515+
// Deprecated: use `authorization` instead.
15161516
// +optional
15171517
BearerTokenFile string `json:"bearerTokenFile,omitempty"`
15181518
// Secret to mount to read bearer token for scraping targets. The secret
15191519
// needs to be in the same namespace as the service monitor and accessible by
15201520
// the Prometheus Operator.
1521-
// See https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api-reference/api.md#endpoint
1521+
// Deprecated: use `authorization` instead.
15221522
// +optional
15231523
BearerTokenSecret *corev1.SecretKeySelector `json:"bearerTokenSecret,omitempty"`
1524+
// `authorization` configures the Authorization header credentials to use when
1525+
// scraping the target.
1526+
// See https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api-reference/api.md#endpoint
1527+
//
1528+
// Cannot be set at the same time as `basicAuth`, or `oauth2`.
1529+
//
1530+
// +optional
1531+
Authorization *monitoringv1.SafeAuthorization `json:"authorization,omitempty"`
15241532
// HonorLabels chooses the metric labels on collisions with target labels.
15251533
// See https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api-reference/api.md#endpoint
15261534
// +optional
@@ -2076,6 +2084,7 @@ type ServiceSpec struct {
20762084
// +optional
20772085
ClusterIPs []string `json:"clusterIPs,omitempty"`
20782086
// LoadBalancerIP is the IP address of the load balancer
2087+
// Deprecated: This field is deprecated in the Kubernetes API.
20792088
// +optional
20802089
LoadBalancerIP *string `json:"loadBalancerIP,omitempty"`
20812090
// The extra labels to add to the service.

0 commit comments

Comments
 (0)