Fixing UI handler UT

Author: kumar-shivam-ranjan

tests/unitary/with_extras/aqua/test_deployment.py

@@ -336,8 +336,7 @@ def test_get_deployment_missing_tags(self):
 
             self.app.get(model_deployment_id=TestDataset.MODEL_DEPLOYMENT_ID)
 
-    @patch("ads.aqua.modeldeployment.deployment.load_config")
-    def test_get_deployment_config(self, mock_load_config):
+    def test_get_deployment_config(self):
         """Test for fetching config details for a given deployment."""
 
         config_json = os.path.join(
@@ -351,9 +350,8 @@ def test_get_deployment_config(self, mock_load_config):
         assert result == config
 
         self.app.get_config = MagicMock(return_value=None)
-        mock_load_config.return_value = config
         result = self.app.get_deployment_config(TestDataset.MODEL_ID)
-        assert result == config
+        assert result == None
 
     @patch("ads.aqua.modeldeployment.deployment.get_container_config")
     @patch("ads.aqua.model.AquaModelApp.create")

tests/unitary/with_extras/aqua/test_finetuning.py

@@ -26,7 +26,6 @@
 from ads.model.datascience_model import DataScienceModel
 from ads.model.model_metadata import ModelCustomMetadata
 from ads.aqua.common.errors import AquaValueError
-from ads.aqua.config.config import get_finetuning_config_defaults
 
 
 class FineTuningTestCase(TestCase):
@@ -246,10 +245,6 @@ def test_get_finetuning_config(self):
         result = self.app.get_finetuning_config(model_id="test-model-id")
         assert result == config
 
-        self.app.get_config = MagicMock(return_value=None)
-        result = self.app.get_finetuning_config(model_id="test-model-id")
-        assert result == get_finetuning_config_defaults()
-
     def test_get_finetuning_default_params(self):
         """Test for fetching finetuning config params for a given model."""
 

tests/unitary/with_extras/aqua/test_ui_handler.py

@@ -22,6 +22,7 @@ class TestDataset:
     USER_COMPARTMENT_ID = "ocid1.compartment.oc1..<USER_COMPARTMENT_OCID>"
     USER_PROJECT_ID = "ocid1.datascienceproject.oc1.iad.<USER_PROJECT_OCID>"
     DEPLOYMENT_SHAPE_NAME = "VM.GPU.A10.1"
+    LIMIT_NAME="ds-gpu-a10-count"
 
 
 class TestAquaUIHandler(unittest.TestCase):
@@ -153,14 +154,15 @@ def test_list_subnets(self, mock_list_subnets):
     def test_get_shape_availability(self, mock_get_shape_availability):
         """Test get shape availability."""
         self.ui_handler.request.path = "aqua/shapes/limit"
-        args = {"instance_shape": TestDataset.DEPLOYMENT_SHAPE_NAME}
+        args = {"instance_shape": TestDataset.DEPLOYMENT_SHAPE_NAME,"limit_name":TestDataset.LIMIT_NAME}
         self.ui_handler.get_argument = MagicMock(
             side_effect=lambda arg, default=None: args.get(arg, default)
         )
         self.ui_handler.get()
         mock_get_shape_availability.assert_called_with(
             compartment_id=TestDataset.USER_COMPARTMENT_ID,
             instance_shape=TestDataset.DEPLOYMENT_SHAPE_NAME,
+            limit_name=TestDataset.LIMIT_NAME
         )
 
     @patch("ads.aqua.ui.AquaUIApp.is_bucket_versioned")