Skip to content

Commit f80bb93

Browse files
committed
Fixed bug.
1 parent ebccd08 commit f80bb93

File tree

2 files changed

+14
-9
lines changed

2 files changed

+14
-9
lines changed

ads/model/deployment/model_deployment_infrastructure.py

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,19 @@ def _load_default_properties(self) -> Dict:
223223
if NB_SESSION_OCID:
224224
try:
225225
nb_session = DSCNotebookSession.from_ocid(NB_SESSION_OCID)
226-
nb_config = nb_session.notebook_session_configuration_details
226+
except Exception as e:
227+
logger.warning(
228+
f"Error fetching details about Notebook "
229+
f"session: {NB_SESSION_OCID}. {e}"
230+
)
231+
logger.debug(traceback.format_exc())
232+
233+
nb_config = getattr(
234+
nb_session,
235+
"notebook_session_config_details",
236+
getattr(nb_session, "notebook_session_configuration_details", None),
237+
)
238+
if nb_config:
227239
defaults[self.CONST_SHAPE_NAME] = nb_config.shape
228240

229241
if nb_config.notebook_session_shape_config_details:
@@ -234,13 +246,6 @@ def _load_default_properties(self) -> Dict:
234246
notebook_shape_config_details
235247
)
236248

237-
except Exception as e:
238-
logger.warning(
239-
f"Error fetching details about Notebook "
240-
f"session: {NB_SESSION_OCID}. {e}"
241-
)
242-
logger.debug(traceback.format_exc())
243-
244249
return defaults
245250

246251
@property

ads/model/generic_model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2137,7 +2137,7 @@ def deploy(
21372137
or self.properties.deployment_ocpus
21382138
or MODEL_DEPLOYMENT_INSTANCE_OCPUS,
21392139
deployment_memory_in_gbs = existing_infrastructure.shape_config_details.get(
2140-
"memory_in_gbs", None
2140+
"memoryInGBs", None
21412141
)
21422142
or self.properties.deployment_memory_in_gbs
21432143
or MODEL_DEPLOYMENT_INSTANCE_MEMORY_IN_GBS,

0 commit comments

Comments
 (0)