Skip to content

Commit f6d6fe9

Browse files
committed
ODSC-44980: Fix unittest failures
1 parent b728e27 commit f6d6fe9

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

ads/common/oci_client.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
from oci.resource_search import ResourceSearchClient
1818
from oci.secrets import SecretsClient
1919
from oci.vault import VaultsClient
20-
from oci.feature_store import FeatureStoreClient
21-
2220
logger = logging.getLogger(__name__)
2321

2422

@@ -65,10 +63,15 @@ def _client_impl(self, client):
6563
"ai_language": AIServiceLanguageClient,
6664
"data_labeling_dp": DataLabelingClient,
6765
"data_labeling_cp": DataLabelingManagementClient,
68-
"feature_store": FeatureStoreClient,
6966
"resource_search": ResourceSearchClient,
7067
"data_catalog": DataCatalogClient
7168
}
69+
try:
70+
from oci.feature_store import FeatureStoreClient
71+
client_map["feature_store"] = FeatureStoreClient
72+
except ImportError:
73+
logger.warning("OCI SDK with feature store support is not installed")
74+
pass
7275

7376
assert (
7477
client in client_map

ads/common/oci_mixin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -726,7 +726,7 @@ def update_from_oci_model(
726726
for attr in self.swagger_types.keys():
727727
if (
728728
hasattr(oci_model_instance, attr)
729-
and getattr(oci_model_instance, attr) is not None
729+
and getattr(oci_model_instance, attr)
730730
and (
731731
not hasattr(self, attr)
732732
or not getattr(self, attr)

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ def update_extra_with_internal_packages():
116116
[
117117
extras_require[k]
118118
for k in extras_require
119-
if k not in ["boosted", "opctl", "complete"]
119+
if k not in ["boosted", "opctl", "complete", "mlm_insights"]
120120
],
121121
)
122122
extras_require["all-public"] = reduce(

0 commit comments

Comments
 (0)