Update tests.

qiuosier · qiuosier · commit f1fe6f65633b · 2023-08-22T11:30:17.000-04:00
diff --git a/tests/unitary/default_setup/jobs/test_jobs_pytorch_ddp.py b/tests/unitary/default_setup/jobs/test_jobs_pytorch_ddp.py
@@ -137,12 +137,12 @@ def test_create_job_runs(self, patched_run, *args):
             [
                 {
                     "display_name": "None-0",
-                    "environment_variables": {"RANK": "0", "WORLD_SIZE": "2"},
+                    "environment_variables": {"NODE_RANK": "0", "WORLD_SIZE": "2"},
                 },
                 {
                     "display_name": "None-1",
                     "environment_variables": {
-                        "RANK": "1",
+                        "NODE_RANK": "1",
                         "WORLD_SIZE": "2",
                         "MAIN_JOB_RUN_OCID": test_ocid,
                     },
diff --git a/tests/unitary/with_extras/jobs/test_pytorch_ddp.py b/tests/unitary/with_extras/jobs/test_pytorch_ddp.py
@@ -108,7 +108,7 @@ def test_install_deps(self, run_command):
             cmd_list,
             [
                 "pip install -r abc/requirements.txt",
-                "pip install abc==1.0",
+                "pip install 'abc==1.0'",
             ],
         )
 
@@ -172,7 +172,7 @@ def init_runner(self):
             driver.CONST_ENV_DEEPSPEED: "1",
             driver.OCI__WORKER_COUNT: "1",
             driver.CONST_ENV_LAUNCH_CMD: "accelerate launch train.py --data abc",
-            "RANK": "0",
+            "NODE_RANK": "0",
         },
     )
     @mock.patch("ads.jobs.templates.driver_pytorch.DeepSpeedRunner.run_deepspeed_host")

Original file line number	Diff line number	Diff line change
`@@ -137,12 +137,12 @@ def test_create_job_runs(self, patched_run, *args):`
`137`	`137`	`[`
`138`	`138`	`{`
`139`	`139`	`"display_name": "None-0",`
`140`		`- "environment_variables": {"RANK": "0", "WORLD_SIZE": "2"},`
	`140`	`+ "environment_variables": {"NODE_RANK": "0", "WORLD_SIZE": "2"},`
`141`	`141`	`},`
`142`	`142`	`{`
`143`	`143`	`"display_name": "None-1",`
`144`	`144`	`"environment_variables": {`
`145`		`- "RANK": "1",`
	`145`	`+ "NODE_RANK": "1",`
`146`	`146`	`"WORLD_SIZE": "2",`
`147`	`147`	`"MAIN_JOB_RUN_OCID": test_ocid,`
`148`	`148`	`},`
Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ def test_install_deps(self, run_command):`
`108`	`108`	`cmd_list,`
`109`	`109`	`[`
`110`	`110`	`"pip install -r abc/requirements.txt",`
`111`		`- "pip install abc==1.0",`
	`111`	`+ "pip install 'abc==1.0'",`
`112`	`112`	`],`
`113`	`113`	`)`
`114`	`114`
`@@ -172,7 +172,7 @@ def init_runner(self):`
`172`	`172`	`driver.CONST_ENV_DEEPSPEED: "1",`
`173`	`173`	`driver.OCI__WORKER_COUNT: "1",`
`174`	`174`	`driver.CONST_ENV_LAUNCH_CMD: "accelerate launch train.py --data abc",`
`175`		`- "RANK": "0",`
	`175`	`+ "NODE_RANK": "0",`
`176`	`176`	`},`
`177`	`177`	`)`
`178`	`178`	`@mock.patch("ads.jobs.templates.driver_pytorch.DeepSpeedRunner.run_deepspeed_host")`