Skip to content

Commit e48a966

Browse files
committed
clean up and fixes
1 parent de56ae2 commit e48a966

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

ads/opctl/operator/lowcode/forecast/whatifserve/deployment_manager.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import pandas as pd
1313
from joblib import dump
1414

15+
from ads.opctl import logger
1516
from ads.common.model_export_util import prepare_generic_model
1617
from ads.opctl.operator.lowcode.common.utils import write_data, call_pandas_fsspec
1718

@@ -22,7 +23,6 @@
2223
class ModelDeploymentManager:
2324
def __init__(self, spec: ForecastOperatorSpec, additional_data: AdditionalData, previous_model_version=None):
2425
self.spec = spec
25-
# self.model_path = spec.output_directory.url
2626
self.model_name = spec.model
2727
self.horizon = spec.horizon
2828
self.additional_data = additional_data.get_dict_by_series()
@@ -51,7 +51,7 @@ def _satiny_test(self):
5151
additional_data_uri = "additional_data_uri"
5252
input_data = {additional_data_uri: temp_file.name}
5353
prediction_test = predict(input_data, _)
54-
print(f"prediction test completed with result :{prediction_test}")
54+
logger.info(f"prediction test completed with result :{prediction_test}")
5555

5656
def _copy_score_file(self):
5757
"""
@@ -62,9 +62,9 @@ def _copy_score_file(self):
6262
score_file = os.path.join(current_dir, "score.py")
6363
destination_file = os.path.join(self.path_to_artifact, os.path.basename(score_file))
6464
shutil.copy2(score_file, destination_file)
65-
print(f"score.py copied successfully to {self.path_to_artifact}")
65+
logger.info(f"score.py copied successfully to {self.path_to_artifact}")
6666
except Exception as e:
67-
print(f"Error copying file: {e}")
67+
logger.warn(f"Error copying file: {e}")
6868
raise e
6969

7070
def save_to_catalog(self):
@@ -82,7 +82,7 @@ def save_to_catalog(self):
8282

8383
self._copy_score_file()
8484
self._satiny_test()
85-
85+
8686
if isinstance(self.model_obj, dict):
8787
series = self.model_obj.keys()
8888
else:
@@ -96,7 +96,7 @@ def save_to_catalog(self):
9696
catalog_id = catalog_entry.id
9797

9898

99-
print(f"Saved {self.model_name} version-v{self.model_version} to model catalog"
99+
logger.info(f"Saved {self.model_name} version-v{self.model_version} to model catalog"
100100
f" with catalog id : {catalog_id}")
101101

102102
catalog_mapping = {"catalog_id": catalog_id, "series": list(series)}

ads/opctl/operator/lowcode/forecast/whatifserve/score.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -135,21 +135,22 @@ def post_inference(yhat):
135135
def get_forecast(future_df, series_id, model_object, date_col, target_column, target_cat_col, horizon):
136136
date_col_name = date_col["name"]
137137
date_col_format = date_col["format"]
138+
future_df[target_cat_col] = future_df[target_cat_col].astype("str")
138139
future_df[date_col_name] = pd.to_datetime(
139140
future_df[date_col_name], format=date_col_format
140141
)
141142
if isinstance(model_object, AutoTS):
142-
full_data_indexed = future_df
143+
series_id_col = "Series"
144+
full_data_indexed = future_df.rename(columns={target_cat_col: series_id_col})
143145
additional_regressors = list(
144-
set(full_data_indexed.columns) - {target_column, target_cat_col, date_col_name}
146+
set(full_data_indexed.columns) - {target_column, series_id_col, date_col_name}
145147
)
146-
future_regressor = full_data_indexed.reset_index().pivot(
148+
future_reg = full_data_indexed.reset_index().pivot(
147149
index=date_col_name,
148-
columns=target_cat_col,
150+
columns=series_id_col,
149151
values=additional_regressors,
150152
)
151-
regr_fcst = future_regressor
152-
pred_obj = model_object.predict(future_regressor=regr_fcst)
153+
pred_obj = model_object.predict(future_regressor=future_reg)
153154
return pred_obj.forecast[series_id].tolist()
154155
elif series_id in model_object and isinstance(model_object[series_id], Prophet):
155156
model = model_object[series_id]

0 commit comments

Comments
 (0)