Skip to content

Commit d41e081

Browse files
committed
addressed comments
1 parent ca36251 commit d41e081

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

ads/common/decorator/runtime_dependency.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,9 @@ class OptionalDependency:
6464
OPTUNA = "oracle-ads[optuna]"
6565
SPARK = "oracle-ads[spark]"
6666
HUGGINGFACE = "oracle-ads[huggingface]"
67-
GREAT_EXPECTATIONS = "oracle-ads[great-expectations]"
67+
FEATURE_STORE = "oracle-ads[feature-store]"
6868
GRAPHVIZ = "oracle-ads[graphviz]"
6969
MLM_INSIGHTS = "oracle-ads[mlm_insights]"
70-
PYARROW = "oracle-ads[pyarrow]"
7170

7271

7372
def runtime_dependency(

ads/feature_store/data_validation/great_expectation.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
from great_expectations.validator.validator import Validator
2222
except ModuleNotFoundError:
2323
raise ModuleNotFoundError(
24-
f"The `great-expectations` module was not found. Please run `pip install "
25-
f"{OptionalDependency.GREAT_EXPECTATIONS}`."
24+
f"The `feature-store` module was not found. Please run `pip install "
25+
f"{OptionalDependency.FEATURE_STORE}`."
2626
)
2727
except Exception as e:
2828
raise

setup.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,13 @@
7272
"bds": ["ibis-framework[impala]", "hdfs[kerberos]", "sqlalchemy"],
7373
"spark": ["pyspark>=3.0.0", "delta-spark"],
7474
"huggingface": ["transformers"],
75-
"great-expectations": ["great-expectations==0.15.39"],
75+
"feature-store": [
76+
"pyspark>=3.0.0",
77+
"delta-spark",
78+
"great-expectations==0.15.39",
79+
"pyarrow"
80+
],
7681
"mlm_insights": ["mlm_insights==0.1.0.dev1"],
77-
"pyarrow": ["pyarrow"],
7882
}
7983

8084
this_directory = Path(__file__).parent

0 commit comments

Comments
 (0)