Skip to content

Commit bb94e65

Browse files
harsh97guptadivyank
authored andcommitted
fix failing tests
1 parent b8f9c16 commit bb94e65

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

ads/feature_store/dataset.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -862,6 +862,7 @@ def get_last_job(self) -> "DatasetJob":
862862
return ds_job[0]
863863
return DatasetJob.from_id(self.job_id)
864864

865+
@deprecated(details="preview functionality is deprecated. Please use as_of.")
865866
def preview(
866867
self,
867868
row_count: int = 10,

tests/integration/feature_store/test_feature_group_dataset_listing.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,9 @@ def test_feature_group_listing_without_limit(self):
9292
fg1.materialise(self.data)
9393
fg1.materialise(self.data2)
9494

95-
fg1_job_list = FeatureGroupJob.list(compartment_id=self.COMPARTMENT_ID)
95+
fg1_job_list = FeatureGroupJob.list(
96+
compartment_id=self.COMPARTMENT_ID, feature_group_id=fg1.id
97+
)
9698
assert fg1_job_list is not None
9799
assert len(fg1_job_list) == 2
98100

@@ -102,7 +104,9 @@ def test_feature_group_listing_without_limit(self):
102104
assert fg2.oci_feature_group.id
103105
fg2.materialise(self.data3)
104106

105-
fg_list = FeatureGroup.list(compartment_id=self.COMPARTMENT_ID)
107+
fg_list = FeatureGroup.list(
108+
compartment_id=self.COMPARTMENT_ID, feature_store_id=fs.id
109+
)
106110
assert fg_list is not None
107111
assert len(fg_list) == 2
108112

@@ -175,7 +179,9 @@ def test_dataset_listing_without_limit(self):
175179
assert dataset.oci_dataset.id
176180

177181
dataset.materialise()
178-
ds_list = Dataset.list(compartment_id=self.COMPARTMENT_ID)
182+
ds_list = Dataset.list(
183+
compartment_id=self.COMPARTMENT_ID, feature_store_id=fs.id
184+
)
179185
assert ds_list is not None
180186
assert len(ds_list) == 1
181187

0 commit comments

Comments
 (0)