moved to ads logging API for creating log

Author: prasankh

ads/opctl/operator/common/utils.py

@@ -18,7 +18,7 @@
 from cerberus import Validator
 
 from ads.opctl import logger, utils
-import oci
+from ads.common.oci_logging import OCILog
 
 CONTAINER_NETWORK = "CONTAINER_NETWORK"
 
@@ -194,40 +194,15 @@ def print_traceback():
         traceback.print_tb(tb)
 
 
-def create_log_in_log_group(signer, log_group_id, log_name=None):
+def create_log_in_log_group(compartment_id, log_group_id, auth, log_name=None):
     """
     Creates a log within a given log group
-    :param signer: The signer
-    :param log_group_id: The OCID of the log group.
-    :param log_name: Name of the log to be created.
-    :return: Created log id.
     """
-
     if not log_name:
         log_name = f"log-{int(time.time())}-{uuid.uuid4()}"
-    logging_client = oci.logging.LoggingManagementClient(config={}, signer=signer)
-
-    log_details = oci.logging.models.CreateLogDetails(
-        display_name=log_name,
-        log_type="CUSTOM",
-        is_enabled=True
-    )
-
-    response = logging_client.create_log(
-        log_group_id=log_group_id,
-        create_log_details=log_details
-    )
-
-    wait_for_resource_id = response.headers['opc-work-request-id']
-    lowered_wait_for_states = ["succeeded", "failed"]
-    try:
-        waiter_result = oci.wait_until(
-            logging_client,
-            logging_client.get_work_request(wait_for_resource_id),
-            evaluate_response=lambda r: getattr(r.data, 'status')
-                                        and getattr(r.data, 'status').lower() in lowered_wait_for_states,
-        )
-        log_id = waiter_result.data.resources[0].identifier
-        return log_id
-    except Exception as e:
-        raise oci.exceptions.CompositeOperationError(partial_results=[response], cause=e)
+    log = OCILog(display_name=log_name,
+                 log_group_id=log_group_id,
+                 compartment_id=compartment_id,
+                 **auth).create()
+    logger.info(f"Created log with log OCID {log.id}")
+    return log.id

ads/opctl/operator/lowcode/forecast/whatifserve/deployment_manager.py

@@ -186,8 +186,9 @@ def create_deployment(self):
         log_group = self.spec.what_if_analysis.model_deployment.log_group
         log_id = self.spec.what_if_analysis.model_deployment.log_id
         if not log_id and not self.test_mode:
-            auth = oci.auth.signers.get_resource_principals_signer()
-            log_id = create_log_in_log_group(auth, log_group)
+            signer = oci.auth.signers.get_resource_principals_signer()
+            auth = {"signer": signer, "config": {}}
+            log_id = create_log_in_log_group(self.compartment_id, log_group, auth)
 
         logs_configuration_details_object = CategoryLogDetails(
             access=LogDetails(log_group_id=log_group,