Skip to content

Commit ab5f89d

Browse files
authored
ODSC-46123. Add subnetId to jobs integration tests (#286)
1 parent 1cc1911 commit ab5f89d

File tree

3 files changed

+65
-163
lines changed

3 files changed

+65
-163
lines changed

tests/integration/jobs/test_dsc_job.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,11 @@ class DSCJobTestCase(unittest.TestCase):
7474
@property
7575
def default_datascience_job(self):
7676
random.seed(self.random_seed)
77-
return DataScienceJob().with_project_id(self.PROJECT_ID)
77+
return (
78+
DataScienceJob()
79+
.with_project_id(self.PROJECT_ID)
80+
.with_subnet_id(self.SUBNET_ID)
81+
)
7882

7983
@classmethod
8084
def setUpClass(cls) -> None:
@@ -632,7 +636,7 @@ def assert_infra_before_build(self, infra):
632636
self.assertEqual(infra.project_id, self.PROJECT_ID)
633637
self.assertEqual(infra.compartment_id, None)
634638
self.assertEqual(infra.block_storage_size, None)
635-
self.assertEqual(infra.subnet_id, None)
639+
self.assertEqual(infra.subnet_id, self.SUBNET_ID)
636640

637641
def test_build_job_within_notebook(self):
638642
job = (
@@ -666,4 +670,4 @@ def test_build_job_outside_notebook(self):
666670
self.assertEqual(job.infrastructure.project_id, self.PROJECT_ID)
667671
self.assertEqual(job.infrastructure.compartment_id, self.COMPARTMENT_ID)
668672
self.assertEqual(job.infrastructure.block_storage_size, 50)
669-
self.assertEqual(job.infrastructure.subnet_id, None)
673+
self.assertEqual(job.infrastructure.subnet_id, self.SUBNET_ID)

tests/integration/jobs/test_jobs_managed_egress.py

Lines changed: 0 additions & 133 deletions
This file was deleted.

0 commit comments

Comments
 (0)