Skip to content

Commit a5698d3

Browse files
committed
logging error in case of all forecast is NaN
1 parent 4f189ef commit a5698d3

File tree

6 files changed

+14
-5
lines changed

6 files changed

+14
-5
lines changed

ads/opctl/operator/lowcode/forecast/model/arima.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,8 @@ def _train_model(self, i, s_id, df, model_kwargs):
127127
logger.debug("===========Done===========")
128128
except Exception as e:
129129
self.errors_dict[s_id] = {"model_name": self.spec.model, "error": str(e)}
130-
logger.debug(f"Encountered Error: {e}. Skipping.")
130+
logger.warn(f"Encountered Error: {e}. Skipping.")
131+
logger.warn(traceback.format_exc())
131132

132133
def _build_model(self) -> pd.DataFrame:
133134
full_data_dict = self.datasets.get_data_by_series()

ads/opctl/operator/lowcode/forecast/model/automlx.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,9 @@ def _build_model(self) -> pd.DataFrame:
149149
if f"{target}_ci_lower" not in summary_frame:
150150
summary_frame[f"{target}_ci_lower"] = np.NAN
151151

152+
if summary_frame[target].isna().all():
153+
raise ValueError("The forecasts are completely NaN")
154+
152155
self.forecast_output.populate_series_output(
153156
series_id=s_id,
154157
fit_val=fitted_values,
@@ -168,7 +171,8 @@ def _build_model(self) -> pd.DataFrame:
168171
"model_name": self.spec.model,
169172
"error": str(e),
170173
}
171-
logger.debug(f"Encountered Error: {e}. Skipping.")
174+
logger.warn(f"Encountered Error: {e}. Skipping.")
175+
logger.warn(traceback.format_exc())
172176

173177
logger.debug("===========Forecast Generated===========")
174178

ads/opctl/operator/lowcode/forecast/model/autots.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,8 @@ def _build_model(self) -> pd.DataFrame:
209209
"model_name": self.spec.model,
210210
"error": str(e),
211211
}
212-
logger.debug(f"Encountered Error: {e}. Skipping.")
212+
logger.warn(f"Encountered Error: {e}. Skipping.")
213+
logger.warn(traceback.format_exc())
213214

214215
logger.debug("===========Done===========")
215216

ads/opctl/operator/lowcode/forecast/model/ml_forecast.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,8 @@ def _train_model(self, data_train, data_test, model_kwargs):
165165
"model_name": self.spec.model,
166166
"error": str(e),
167167
}
168-
logger.debug(f"Encountered Error: {e}. Skipping.")
168+
logger.warn(f"Encountered Error: {e}. Skipping.")
169+
logger.warn(traceback.format_exc())
169170
raise e
170171

171172
def _build_model(self) -> pd.DataFrame:

ads/opctl/operator/lowcode/forecast/model/neuralprophet.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,7 @@ def _train_model(self, i, s_id, df, model_kwargs):
218218
logger.debug("===========Done===========")
219219
except Exception as e:
220220
self.errors_dict[s_id] = {"model_name": self.spec.model, "error": str(e)}
221+
logger.warn(traceback.format_exc())
221222
raise e
222223

223224
def _build_model(self) -> pd.DataFrame:

ads/opctl/operator/lowcode/forecast/model/prophet.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,8 @@ def _train_model(self, i, series_id, df, model_kwargs):
131131
"model_name": self.spec.model,
132132
"error": str(e),
133133
}
134-
logger.debug(f"Encountered Error: {e}. Skipping.")
134+
logger.warn(f"Encountered Error: {e}. Skipping.")
135+
logger.warn(traceback.format_exc())
135136

136137
def _build_model(self) -> pd.DataFrame:
137138
full_data_dict = self.datasets.get_data_by_series()

0 commit comments

Comments
 (0)