Skip to content

Commit a4539ba

Browse files
committed
Fixed unit test.
1 parent 7b36dfd commit a4539ba

File tree

2 files changed

+205
-164
lines changed

2 files changed

+205
-164
lines changed

tests/unitary/default_setup/model_deployment/test_model_deployment_v2.py

Lines changed: 27 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1196,50 +1196,56 @@ def test_deploy_failed(
11961196
)
11971197
mock_sync.assert_called()
11981198

1199-
@patch.object(OCIDataScienceMixin, "sync")
12001199
@patch.object(
1201-
oci.data_science.DataScienceClient,
1202-
"activate_model_deployment",
1200+
OCIDataScienceModelDeployment,
1201+
"activate",
12031202
)
1204-
def test_activate(self, mock_activate_model_deployment, mock_sync):
1203+
def test_activate(self, mock_activate):
12051204
response = MagicMock()
12061205
response.data = OCI_MODEL_DEPLOYMENT_RESPONSE
1207-
mock_activate_model_deployment.return_value = response
1206+
mock_activate.return_value = response
12081207
model_deployment = self.initialize_model_deployment()
12091208
model_deployment.dsc_model_deployment.id = "test_model_deployment_id"
12101209
model_deployment.activate(wait_for_completion=False)
1211-
mock_activate_model_deployment.assert_called_with("test_model_deployment_id")
1212-
mock_sync.assert_called()
1210+
mock_activate.assert_called_with(
1211+
wait_for_completion=False,
1212+
max_wait_time=1200,
1213+
poll_interval=10
1214+
)
12131215

1214-
@patch.object(OCIDataScienceMixin, "sync")
12151216
@patch.object(
1216-
oci.data_science.DataScienceClient,
1217-
"deactivate_model_deployment",
1217+
OCIDataScienceModelDeployment,
1218+
"deactivate",
12181219
)
1219-
def test_deactivate(self, mock_deactivate_model_deployment, mock_sync):
1220+
def test_deactivate(self, mock_deactivate):
12201221
response = MagicMock()
12211222
response.data = OCI_MODEL_DEPLOYMENT_RESPONSE
1222-
mock_deactivate_model_deployment.return_value = response
1223+
mock_deactivate.return_value = response
12231224
model_deployment = self.initialize_model_deployment()
12241225
model_deployment.dsc_model_deployment.id = "test_model_deployment_id"
12251226
model_deployment.deactivate(wait_for_completion=False)
1226-
mock_deactivate_model_deployment.assert_called_with("test_model_deployment_id")
1227-
mock_sync.assert_called()
1227+
mock_deactivate.assert_called_with(
1228+
wait_for_completion=False,
1229+
max_wait_time=1200,
1230+
poll_interval=10
1231+
)
12281232

1229-
@patch.object(OCIDataScienceMixin, "sync")
12301233
@patch.object(
1231-
oci.data_science.DataScienceClient,
1232-
"delete_model_deployment",
1234+
OCIDataScienceModelDeployment,
1235+
"delete",
12331236
)
1234-
def test_delete(self, mock_delete_model_deployment, mock_sync):
1237+
def test_delete(self, mock_delete):
12351238
response = MagicMock()
12361239
response.data = OCI_MODEL_DEPLOYMENT_RESPONSE
1237-
mock_delete_model_deployment.return_value = response
1240+
mock_delete.return_value = response
12381241
model_deployment = self.initialize_model_deployment()
12391242
model_deployment.dsc_model_deployment.id = "test_model_deployment_id"
12401243
model_deployment.delete(wait_for_completion=False)
1241-
mock_delete_model_deployment.assert_called_with("test_model_deployment_id")
1242-
mock_sync.assert_called()
1244+
mock_delete.assert_called_with(
1245+
wait_for_completion=False,
1246+
max_wait_time=1200,
1247+
poll_interval=10
1248+
)
12431249

12441250
@patch.object(OCIDataScienceMixin, "sync")
12451251
@patch.object(

0 commit comments

Comments
 (0)