Skip to content

Commit a16d479

Browse files
committed
Update unit tests to set compartment ID if it is not available from env.
1 parent 5049b0e commit a16d479

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

tests/unitary/default_setup/catalog/test_catalog_notebook.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,14 +66,16 @@ class NotebookCatalogTest(unittest.TestCase):
6666

6767
with patch.object(auth, "default_signer"):
6868
with patch.object(oci_client, "OCIClientFactory"):
69-
notebook_catalog = NotebookCatalog()
70-
notebook_catalog.ds_client = MagicMock()
71-
notebook_catalog.identity_client = MagicMock()
72-
7369
notebook_id = "ocid1.notebookcatalog.oc1.iad.<unique_ocid>"
74-
comp_id = os.environ.get("NB_SESSION_COMPARTMENT_OCID")
70+
comp_id = os.environ.get(
71+
"NB_SESSION_COMPARTMENT_OCID", "ocid1.compartment.oc1.iad.<unique_ocid>"
72+
)
7573
date_time = datetime(2020, 7, 1, 18, 24, 42, 110000, tzinfo=timezone.utc)
7674

75+
notebook_catalog = NotebookCatalog(compartment_id=comp_id)
76+
notebook_catalog.ds_client = MagicMock()
77+
notebook_catalog.identity_client = MagicMock()
78+
7779
nsl = NotebookSummaryList(generate_notebook_list())
7880

7981
@staticmethod

tests/unitary/default_setup/catalog/test_catalog_project.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,14 +61,14 @@ class ProjectCatalogTest(unittest.TestCase):
6161

6262
with patch.object(auth, "default_signer"):
6363
with patch.object(oci_client, "OCIClientFactory"):
64-
pc = ProjectCatalog()
65-
pc.ds_client = MagicMock()
66-
pc.identity_client = MagicMock()
67-
6864
project_id = "ocid1.projectcatalog.oc1.iad.<unique_ocid>"
69-
comp_id = os.environ.get("NB_SESSION_COMPARTMENT_OCID")
65+
comp_id = os.environ.get("NB_SESSION_COMPARTMENT_OCID", "ocid1.compartment.oc1.iad.<unique_ocid>")
7066
date_time = datetime(2020, 7, 1, 18, 24, 42, 110000, tzinfo=timezone.utc)
7167

68+
pc = ProjectCatalog(compartment_id=comp_id)
69+
pc.ds_client = MagicMock()
70+
pc.identity_client = MagicMock()
71+
7272
psl = ProjectSummaryList(generate_project_list())
7373

7474
@staticmethod

0 commit comments

Comments
 (0)