Skip to content

Commit 9f1cf64

Browse files
committed
added id in the table
1 parent a58f74a commit 9f1cf64

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

ads/feature_store/common/utils/utility.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,21 +118,25 @@ def validate_delta_format_parameters(
118118

119119

120120
def show_ingestion_summary(
121-
entity_type: EntityType = EntityType.FEATURE_GROUP, error_details: str = None
121+
entity_id: str,
122+
entity_type: EntityType = EntityType.FEATURE_GROUP,
123+
error_details: str = None,
122124
):
123125
"""
124126
Displays a ingestion summary table with the given entity type and error details.
125127
126128
Args:
129+
entity_id: str
127130
entity_type (EntityType, optional): The type of entity being ingested. Defaults to EntityType.FEATURE_GROUP.
128131
error_details (str, optional): Details of any errors that occurred during ingestion. Defaults to None.
129132
"""
130133
from tabulate import tabulate
131134

132-
table_headers = ["entity_type", "ingestion_status", "error_details"]
135+
table_headers = ["entity_id", "entity_type", "ingestion_status", "error_details"]
133136
ingestion_status = "Failed" if error_details else "Succeeded"
134137

135138
table_values = [
139+
entity_id,
136140
entity_type.value,
137141
ingestion_status,
138142
error_details if error_details else "None",

ads/feature_store/execution_strategy/spark/spark_execution.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,9 @@ def _save_offline_dataframe(
289289
)
290290

291291
show_ingestion_summary(
292-
entity_type=EntityType.FEATURE_GROUP, error_details=error_details
292+
entity_id=feature_group.id,
293+
entity_type=EntityType.FEATURE_GROUP,
294+
error_details=error_details,
293295
)
294296

295297
output_details = {
@@ -422,7 +424,9 @@ def _save_dataset_input(self, dataset, dataset_job: DatasetJob):
422424
)
423425

424426
show_ingestion_summary(
425-
entity_type=EntityType.DATASET, error_details=error_details
427+
entity_id=dataset.id,
428+
entity_type=EntityType.DATASET,
429+
error_details=error_details,
426430
)
427431

428432
output_details = {

0 commit comments

Comments
 (0)