'fix minor bugs

Author: guptadivyank

ads/feature_store/dataset.py

@@ -28,7 +28,6 @@
 from ads.feature_store.execution_strategy.execution_strategy_provider import (
     OciExecutionStrategyProvider,
 )
-from ads.feature_store.feature import Feature
 from ads.feature_store.feature import DatasetFeature
 from ads.feature_store.feature_group_expectation import Expectation
 from ads.feature_store.feature_option_details import FeatureOptionDetails
@@ -247,7 +246,7 @@ def id(self) -> str:
         return self.get_spec(self.CONST_ID)
 
     @property
-    def features(self) -> List[Feature]:
+    def features(self) -> List[DatasetFeature]:
         return [
             DatasetFeature(**feature_dict)
             for feature_dict in self.get_spec(self.CONST_OUTPUT_FEATURE_DETAILS)[
@@ -259,7 +258,6 @@ def features(self) -> List[Feature]:
     def with_id(self, id: str) -> "Dataset":
         return self.set_spec(self.CONST_ID, id)
 
-
     def with_job_id(self, dataset_job_id: str) -> "Dataset":
         """Sets the job_id for the last running job.
 
@@ -721,12 +719,12 @@ def delete(self):
 
         dataset_execution_strategy.delete_dataset(self, dataset_job)
 
-    def get_features(self) -> List[Feature]:
+    def get_features(self) -> List[DatasetFeature]:
         """
         Returns all the features in the dataset.
 
         Returns:
-            List[Feature]
+            List[DatasetFeature]
         """
 
         return self.features
@@ -740,13 +738,9 @@ def get_features_df(self) -> "pandas.DataFrame":
         """
         records = []
         for feature in self.features:
-            records.append(
-                {
-                    "name": feature.feature_name,
-                    "type": feature.feature_type
-                }
-            )
+            records.append({"name": feature.feature_name, "type": feature.feature_type})
         return pandas.DataFrame.from_records(records)
+
     def update(self, **kwargs) -> "Dataset":
         """Updates Dataset in the feature store.
 
@@ -794,9 +788,7 @@ def _update_from_oci_dataset_model(self, oci_dataset: OCIDataset) -> "Dataset":
                     # May not need if we fix the backend and add feature_group_id to the output_feature
                     features_list = []
                     for output_feature in dataset_details[infra_attr]["items"]:
-                        output_feature["datasetId"] = dataset_details[
-                            self.CONST_ID
-                        ]
+                        output_feature["datasetId"] = dataset_details[self.CONST_ID]
                         features_list.append(output_feature)
 
                     value = {self.CONST_ITEMS: features_list}

ads/feature_store/docs/source/dataset.rst

@@ -227,23 +227,14 @@ The ``get_statistics()`` method takes the following optional parameter:
 
 Get features
 ============
-You can call the ``get_features_dataframe()`` method of the Dataset instance to fetch features in a dataset.
+You can call the ``get_features_df()`` method of the Dataset instance to fetch features in a dataset.
 
 .. code-block:: python3
 
   # Fetch features for a dataset
-  df = dataset.get_features_dataframe()
+  df = dataset.get_features_df()
   df.show()
 
-Get input schema details
-========================
-You can call the ``get_input_schema_dataframe()`` method of the Dataset instance to fetch input schema details of a dataset.
-
-.. code-block:: python3
-
-  # Fetch input schema details for a dataset
-  df = dataset.get_input_schema_dataframe()
-  df.show()
 
 Preview
 ========

ads/feature_store/feature_group.py

@@ -753,8 +753,7 @@ def get_features_df(self) -> "pd.DataFrame":
             records.append(
                 {
                     "name": feature.feature_name,
-                    "type": feature.feature_type,
-                    "feature_group_id": feature.feature_group_id,
+                    "type": feature.feature_type
                 }
             )
         return pd.DataFrame.from_records(records)