Skip to content

Commit 96e8ed4

Browse files
committed
Addressing review comments
1 parent b2952bd commit 96e8ed4

File tree

3 files changed

+22
-0
lines changed

3 files changed

+22
-0
lines changed

THIRD_PARTY_LICENSES.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,12 @@ pandavro
229229
* Source code: https://github.com/ynqa/pandavro
230230
* Project home: https://github.com/ynqa/pandavro
231231

232+
plotly
233+
* Copyright (c) 2016-2018 Plotly, Inc
234+
* License: MIT License
235+
* Source code: https://github.com/plotly/plotly.py
236+
* Project home: https://plotly.com/
237+
232238
protobuf
233239
* Copyright 2008 Google Inc. All rights reserved.
234240
* License: Google Protobuf License

ads/feature_store/statistics/charts/box_plot.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,16 @@ def __init__(
6666
self.box_points = box_points
6767
super().__init__()
6868

69+
def __validate__(self):
70+
if (
71+
self.q1 is None
72+
or self.q3 is None
73+
or self.iqr is None
74+
or type(self.box_points) is not list
75+
or len(self.box_points) == 0
76+
):
77+
return self.ValidationFailedException()
78+
6979
def add_to_figure(self, fig: Figure, xaxis: int, yaxis: int):
7080
xaxis_str, yaxis_str, x_str, y_str = self.get_x_y_str_axes(xaxis, yaxis)
7181
fig.add_box(

ads/feature_store/statistics/statistics.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,12 @@ def kind(self) -> str:
2727
return "statistics"
2828

2929
def to_viz(self, feature_list: List[str] = None):
30+
"""Visualises statistics inside notebook
31+
Parameters
32+
----------
33+
feature_list: (str, optional). Defaults to `None`.
34+
The specific features of the FeatureGroup or Dataset we want to visualise
35+
"""
3036
if self.content is not None:
3137
[
3238
FeatureStatistics.from_json(feature, stat).to_viz()

0 commit comments

Comments
 (0)