Skip to content

Commit 967de01

Browse files
authored
Bugfix for create evaluation API (#1010)
2 parents 0424f3d + 2cbe281 commit 967de01

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

ads/aqua/evaluation/entities.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class CreateAquaEvaluationDetails(Serializable):
8383
ocpus: Optional[float] = None
8484
log_group_id: Optional[str] = None
8585
log_id: Optional[str] = None
86-
metrics: Optional[List[str]] = None
86+
metrics: Optional[List[Dict[str, Any]]] = None
8787
force_overwrite: Optional[bool] = False
8888

8989
class Config:
@@ -140,7 +140,7 @@ class AquaEvaluationCommands(Serializable):
140140
evaluation_id: str
141141
evaluation_target_id: str
142142
input_data: Dict[str, Any]
143-
metrics: List[str]
143+
metrics: List[Dict[str, Any]]
144144
output_dir: str
145145
params: Dict[str, Any]
146146

ads/aqua/evaluation/evaluation.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,8 @@ def create(
159159
create_aqua_evaluation_details = CreateAquaEvaluationDetails(**kwargs)
160160
except Exception as ex:
161161
custom_errors = {
162-
".".join(map(str, e["loc"])): e["msg"] for e in json.loads(ex.json())
162+
".".join(map(str, e["loc"])): e["msg"]
163+
for e in json.loads(ex.json())
163164
}
164165
raise AquaValueError(
165166
f"Invalid create evaluation parameters. Error details: {custom_errors}."
@@ -619,11 +620,6 @@ def _build_launch_cmd(
619620
evaluation_id=evaluation_id,
620621
evaluation_target_id=evaluation_source_id,
621622
input_data={
622-
"columns": {
623-
"prompt": "prompt",
624-
"completion": "completion",
625-
"category": "category",
626-
},
627623
"format": Path(dataset_path).suffix,
628624
"url": dataset_path,
629625
},

0 commit comments

Comments
 (0)