Skip to content

Commit 90855ee

Browse files
yogesh266guptadivyank
authored andcommitted
code changes for dataset interface
1 parent 65f1a97 commit 90855ee

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

ads/feature_store/dataset.py

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ def id(self) -> str:
249249
@property
250250
def features(self) -> List[Feature]:
251251
return [
252-
Feature(**feature_dict)
252+
DatasetFeature(**feature_dict)
253253
for feature_dict in self.get_spec(self.CONST_OUTPUT_FEATURE_DETAILS)[
254254
self.CONST_ITEMS
255255
]
@@ -743,8 +743,7 @@ def get_features_df(self) -> "pandas.DataFrame":
743743
records.append(
744744
{
745745
"name": feature.feature_name,
746-
"type": feature.feature_type,
747-
"feature_group_id": feature.feature_group_id,
746+
"type": feature.feature_type
748747
}
749748
)
750749
return pandas.DataFrame.from_records(records)
@@ -791,7 +790,20 @@ def _update_from_oci_dataset_model(self, oci_dataset: OCIDataset) -> "Dataset":
791790

792791
for infra_attr, dsc_attr in self.attribute_map.items():
793792
if infra_attr in dataset_details:
794-
self.set_spec(infra_attr, dataset_details[infra_attr])
793+
if infra_attr == self.CONST_OUTPUT_FEATURE_DETAILS:
794+
# May not need if we fix the backend and add feature_group_id to the output_feature
795+
features_list = []
796+
for output_feature in dataset_details[infra_attr]["items"]:
797+
output_feature["datasetId"] = dataset_details[
798+
self.CONST_ID
799+
]
800+
features_list.append(output_feature)
801+
802+
value = {self.CONST_ITEMS: features_list}
803+
else:
804+
value = dataset_details[infra_attr]
805+
806+
self.set_spec(infra_attr, value)
795807

796808
return self
797809

0 commit comments

Comments
 (0)