Skip to content

Commit 8b167ab

Browse files
committed
typo fix, minor improvements
1 parent 9799088 commit 8b167ab

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

ads/opctl/operator/lowcode/forecast/whatifserve/deployment_manager.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def __init__(self, spec: ForecastOperatorSpec, additional_data: AdditionalData,
4949
self.test_mode = os.environ.get("TEST_MODE", False)
5050
self.deployment_info = {}
5151

52-
def _satiny_test(self):
52+
def _sanity_test(self):
5353
"""
5454
Function perform sanity test for saved artifact
5555
"""
@@ -102,7 +102,7 @@ def save_to_catalog(self):
102102
data_science_env=True)
103103

104104
self._copy_score_file()
105-
self._satiny_test()
105+
self._sanity_test()
106106

107107
if isinstance(self.model_obj, dict):
108108
series = self.model_obj.keys()
@@ -119,9 +119,9 @@ def save_to_catalog(self):
119119
self.catalog_id = catalog_entry.id
120120

121121
logger.info(f"Saved {self.model_name} version-v{self.model_version} to model catalog"
122-
f" with catalog id : {self.catalog_id}")
122+
f" with model ocid : {self.catalog_id}")
123123

124-
self.deployment_info = {"catalog_id": self.catalog_id, "series": list(series)}
124+
self.deployment_info = {"model_ocid": self.catalog_id, "series": list(series)}
125125

126126
def create_deployment(self):
127127
"""Create a model deployment serving"""
@@ -199,9 +199,10 @@ def create_deployment(self):
199199
model_deploy_configuration,
200200
wait_for_states=[
201201
"SUCCEEDED", "FAILED"])
202-
self.deployment_info['model_deployment_id'] = model_deployment.data.id
202+
self.deployment_info['work_request'] = model_deployment.data.id
203203
logger.info(f"deployment metadata :{model_deployment.data}")
204204
md = data_science.get_model_deployment(model_deployment_id=model_deployment.data.resources[0].identifier)
205+
self.deployment_info['model_deployment_ocid'] = md.data.id
205206
endpoint_url = md.data.model_deployment_url
206207
self.deployment_info['model_deployment_endpoint'] = f"{endpoint_url}/predict"
207208

0 commit comments

Comments
 (0)