Skip to content

Commit 80cb16c

Browse files
Replace string split with shlex split
1 parent b6dbc5b commit 80cb16c

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

ads/aqua/model/model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -726,7 +726,7 @@ def _create_model_catalog_entry(
726726
cmd_vars = generate_tei_cmd_var(os_path)
727727
metadata.add(
728728
key=AQUA_DEPLOYMENT_CONTAINER_CMD_VAR_METADATA_NAME,
729-
value=",".join(cmd_vars),
729+
value=" ".join(cmd_vars),
730730
description=f"Inference container cmd vars for {model_name}",
731731
category="Other",
732732
)

ads/aqua/modeldeployment/deployment.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
44

55
import logging
6+
import shlex
67
from typing import Dict, List, Optional, Union
78

89
from ads.aqua.app import AquaApp, logger
@@ -271,7 +272,7 @@ def create(
271272
cmd_var_string = aqua_model.custom_metadata_list.get(
272273
AQUA_DEPLOYMENT_CONTAINER_CMD_VAR_METADATA_NAME
273274
).value
274-
default_cmd_var = cmd_var_string.split(",")
275+
default_cmd_var = shlex.split(cmd_var_string)
275276
if default_cmd_var:
276277
cmd_var = validate_cmd_var(default_cmd_var, cmd_var)
277278
logging.info(f"CMD used for deploying {aqua_model.id} :{cmd_var}")

0 commit comments

Comments
 (0)