clean up

Author: VipulMascarenhas

ads/aqua/common/utils.py

@@ -1088,7 +1088,7 @@ def list_hf_models(query: str) -> List[str]:
         raise format_hf_custom_error_message(err) from err
 
 
-def generate_tei_cmd_vars(os_path: str) -> List[str]:
+def generate_tei_cmd_var(os_path: str) -> List[str]:
     """This utility functions generates CMD params for Text Embedding Inference container. Only the
     essential parameters for OCI model deployment are added, defaults are used for the rest.
     Parameters
@@ -1098,15 +1098,16 @@ def generate_tei_cmd_vars(os_path: str) -> List[str]:
 
     Returns
     -------
-        List of command line arguments
+        cmd_var:
+            List of command line arguments
     """
 
     cmd_prefix = "--"
-    cmd_vars = [
+    cmd_var = [
         cmd_prefix + TextEmbeddingInferenceContainerParams.MODEL_ID,
         f"{AQUA_MODEL_DEPLOYMENT_FOLDER}{ObjectStorageDetails.from_path(os_path.rstrip('/')).filepath}/",
         cmd_prefix + TextEmbeddingInferenceContainerParams.PORT,
         TEI_CONTAINER_DEFAULT_HOST,
     ]
 
-    return cmd_vars
+    return cmd_var

ads/aqua/model/model.py

@@ -21,7 +21,7 @@
     _build_resource_identifier,
     copy_model_config,
     create_word_icon,
-    generate_tei_cmd_vars,
+    generate_tei_cmd_var,
     get_artifact_path,
     get_hf_model_info,
     list_os_files_with_extension,
@@ -713,7 +713,7 @@ def _create_model_catalog_entry(
                         category="Other",
                     )
 
-                cmd_vars = generate_tei_cmd_vars(os_path)
+                cmd_vars = generate_tei_cmd_var(os_path)
                 metadata.add(
                     key=AQUA_DEPLOYMENT_CONTAINER_CMD_VAR_METADATA_NAME,
                     value=",".join(cmd_vars),

ads/aqua/modeldeployment/deployment.py

@@ -263,7 +263,7 @@ def create(
                 cmd_var_string = aqua_model.custom_metadata_list.get(
                     AQUA_DEPLOYMENT_CONTAINER_CMD_VAR_METADATA_NAME
                 ).value
-                cmd_var.append(cmd_var_string.split(","))
+                cmd_var.extend(cmd_var_string.split(","))
             except ValueError as err:
                 raise AquaValueError(
                     f"{AQUA_DEPLOYMENT_CONTAINER_CMD_VAR_METADATA_NAME} key is not available in the custom metadata "