Skip to content

Commit 5f20ec3

Browse files
authored
Added support to force overwrite extsing file in object storage. (#789)
2 parents 9c71915 + 2915053 commit 5f20ec3

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

ads/aqua/evaluation.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,8 @@ class CreateAquaEvaluationDetails(DataClassSerializable):
317317
The log id for the evaluation job infrastructure.
318318
metrics: (list, optional). Defaults to `None`.
319319
The metrics for the evaluation.
320+
force_overwrite: (bool, optional). Defaults to `False`.
321+
Whether to force overwrite the existing file in object storage.
320322
"""
321323

322324
evaluation_source_id: str
@@ -337,6 +339,7 @@ class CreateAquaEvaluationDetails(DataClassSerializable):
337339
log_group_id: Optional[str] = None
338340
log_id: Optional[str] = None
339341
metrics: Optional[List] = None
342+
force_overwrite: Optional[bool] = False
340343

341344

342345
class AquaEvaluationApp(AquaApp):
@@ -440,12 +443,12 @@ def create(
440443
src_uri=evaluation_dataset_path,
441444
dst_uri=dst_uri,
442445
auth=default_signer(),
443-
force_overwrite=False,
446+
force_overwrite=create_aqua_evaluation_details.force_overwrite,
444447
)
445448
except FileExistsError:
446449
raise AquaFileExistsError(
447450
f"Dataset {dataset_file} already exists in {create_aqua_evaluation_details.report_path}. "
448-
"Please use a new dataset file name or report path."
451+
"Please use a new dataset file name, report path or set `force_overwrite` as True."
449452
)
450453
logger.debug(
451454
f"Uploaded local file {evaluation_dataset_path} to object storage {dst_uri}."

ads/aqua/finetune.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,8 @@ class CreateFineTuningDetails(DataClassSerializable):
122122
The log group id for fine tuning job infrastructure.
123123
log_id: (str, optional). Defaults to `None`.
124124
The log id for fine tuning job infrastructure.
125+
force_overwrite: (bool, optional). Defaults to `False`.
126+
Whether to force overwrite the existing file in object storage.
125127
"""
126128

127129
ft_source_id: str
@@ -142,6 +144,7 @@ class CreateFineTuningDetails(DataClassSerializable):
142144
subnet_id: Optional[str] = None
143145
log_id: Optional[str] = None
144146
log_group_id: Optional[str] = None
147+
force_overwrite: Optional[bool] = False
145148

146149

147150
class AquaFineTuningApp(AquaApp):
@@ -273,12 +276,12 @@ def create(
273276
src_uri=ft_dataset_path,
274277
dst_uri=dst_uri,
275278
auth=default_signer(),
276-
force_overwrite=False,
279+
force_overwrite=create_fine_tuning_details.force_overwrite,
277280
)
278281
except FileExistsError:
279282
raise AquaFileExistsError(
280283
f"Dataset {dataset_file} already exists in {create_fine_tuning_details.report_path}. "
281-
"Please use a new dataset file name or report path."
284+
"Please use a new dataset file name, report path or set `force_overwrite` as True."
282285
)
283286
logger.debug(
284287
f"Uploaded local file {ft_dataset_path} to object storage {dst_uri}."

0 commit comments

Comments
 (0)