Skip to content

Commit 5d7605b

Browse files
Addressing review comments
1 parent d19d9f3 commit 5d7605b

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

ads/aqua/extension/common_handler.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,17 @@ def get(self):
5757
current_aqua_version = json.loads(read_file(current_aqua_version_path))
5858
current_ads_version = {"ads": metadata.version("oracle_ads")}
5959
current_version = {"installed": {**current_aqua_version, **current_ads_version}}
60-
61-
latest_version_artifact_path = ObjectStorageDetails(
62-
CONDA_BUCKET_NAME, CONDA_BUCKET_NS, "service_pack/aqua_latest_version.json"
63-
).path
64-
65-
latest_version = json.loads(
66-
read_file(latest_version_artifact_path, auth=default_signer())
67-
)
68-
60+
try:
61+
latest_version_artifact_path = ObjectStorageDetails(
62+
CONDA_BUCKET_NAME,
63+
CONDA_BUCKET_NS,
64+
"service_pack/aqua_latest_version.json",
65+
).path
66+
latest_version = json.loads(
67+
read_file(latest_version_artifact_path, auth=default_signer())
68+
)
69+
except Exception:
70+
latest_version = {"latest": current_version["installed"]}
6971
response = {**current_version, **latest_version}
7072
return self.finish(response)
7173

0 commit comments

Comments
 (0)