Skip to content

Commit 4eb17af

Browse files
committed
Move class property initialization into setup class method.
1 parent 81022c3 commit 4eb17af

File tree

2 files changed

+34
-28
lines changed

2 files changed

+34
-28
lines changed

tests/unitary/default_setup/catalog/test_catalog_notebook.py

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -69,27 +69,30 @@ def generate_notebook_list(
6969
class NotebookCatalogTest(unittest.TestCase):
7070
"""Contains test cases for catalog.notebook"""
7171

72-
with patch.object(auth, "default_signer"):
73-
with patch.object(oci_client, "OCIClientFactory"):
74-
notebook_id = "ocid1.notebookcatalog.oc1.iad.<unique_ocid>"
75-
comp_id = os.environ.get(
76-
"NB_SESSION_COMPARTMENT_OCID", "ocid1.compartment.oc1.iad.<unique_ocid>"
77-
)
78-
date_time = datetime(2020, 7, 1, 18, 24, 42, 110000, tzinfo=timezone.utc)
79-
80-
notebook_catalog = NotebookCatalog(compartment_id=comp_id)
81-
notebook_catalog.ds_client = MagicMock()
82-
notebook_catalog.identity_client = MagicMock()
83-
84-
nsl = NotebookSummaryList(generate_notebook_list())
85-
8672
@classmethod
8773
def setUpClass(cls) -> None:
8874
os.environ[
8975
"NB_SESSION_COMPARTMENT_OCID"
9076
] = "ocid1.compartment.oc1.<unique_ocid>"
9177
reload(ads.config)
9278
reload(ads.catalog.notebook)
79+
# Initialize class properties after reloading
80+
with patch.object(auth, "default_signer"):
81+
with patch.object(oci_client, "OCIClientFactory"):
82+
cls.notebook_id = "ocid1.notebookcatalog.oc1.iad.<unique_ocid>"
83+
cls.comp_id = os.environ.get(
84+
"NB_SESSION_COMPARTMENT_OCID",
85+
"ocid1.compartment.oc1.iad.<unique_ocid>",
86+
)
87+
cls.date_time = datetime(
88+
2020, 7, 1, 18, 24, 42, 110000, tzinfo=timezone.utc
89+
)
90+
91+
cls.notebook_catalog = NotebookCatalog(compartment_id=cls.comp_id)
92+
cls.notebook_catalog.ds_client = MagicMock()
93+
cls.notebook_catalog.identity_client = MagicMock()
94+
95+
cls.nsl = NotebookSummaryList(generate_notebook_list())
9396
return super().setUpClass()
9497

9598
@classmethod

tests/unitary/default_setup/catalog/test_catalog_project.py

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -62,27 +62,30 @@ def generate_project_list(
6262
class ProjectCatalogTest(unittest.TestCase):
6363
"""Contains test cases for catalog.project"""
6464

65-
with patch.object(auth, "default_signer"):
66-
with patch.object(oci_client, "OCIClientFactory"):
67-
project_id = "ocid1.projectcatalog.oc1.iad.<unique_ocid>"
68-
comp_id = os.environ.get(
69-
"NB_SESSION_COMPARTMENT_OCID", "ocid1.compartment.oc1.iad.<unique_ocid>"
70-
)
71-
date_time = datetime(2020, 7, 1, 18, 24, 42, 110000, tzinfo=timezone.utc)
72-
73-
pc = ProjectCatalog(compartment_id=comp_id)
74-
pc.ds_client = MagicMock()
75-
pc.identity_client = MagicMock()
76-
77-
psl = ProjectSummaryList(generate_project_list())
78-
7965
@classmethod
8066
def setUpClass(cls) -> None:
8167
os.environ[
8268
"NB_SESSION_COMPARTMENT_OCID"
8369
] = "ocid1.compartment.oc1.<unique_ocid>"
8470
reload(ads.config)
8571
reload(ads.catalog.project)
72+
# Initialize class properties after reloading
73+
with patch.object(auth, "default_signer"):
74+
with patch.object(oci_client, "OCIClientFactory"):
75+
cls.project_id = "ocid1.projectcatalog.oc1.iad.<unique_ocid>"
76+
cls.comp_id = os.environ.get(
77+
"NB_SESSION_COMPARTMENT_OCID",
78+
"ocid1.compartment.oc1.iad.<unique_ocid>",
79+
)
80+
cls.date_time = datetime(
81+
2020, 7, 1, 18, 24, 42, 110000, tzinfo=timezone.utc
82+
)
83+
84+
cls.pc = ProjectCatalog(compartment_id=cls.comp_id)
85+
cls.pc.ds_client = MagicMock()
86+
cls.pc.identity_client = MagicMock()
87+
88+
cls.psl = ProjectSummaryList(generate_project_list())
8689
return super().setUpClass()
8790

8891
@classmethod

0 commit comments

Comments
 (0)