Skip to content

Commit 4d30232

Browse files
committed
model save changes
1 parent ca61db6 commit 4d30232

File tree

3 files changed

+156
-123
lines changed

3 files changed

+156
-123
lines changed

ads/feature_store/common/utils/utility.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
from ads.feature_store.feature_group_expectation import Rule, Expectation
2020
from ads.feature_store.input_feature_detail import FeatureDetail
2121
from ads.feature_store.common.spark_session_singleton import SparkSessionSingleton
22-
22+
import re
2323
try:
2424
from pyspark.pandas import DataFrame
2525
except ModuleNotFoundError:
@@ -401,3 +401,12 @@ def validate_input_feature_details(input_feature_details, data_frame):
401401
if isinstance(data_frame, pd.DataFrame):
402402
return convert_pandas_datatype_with_schema(input_feature_details, data_frame)
403403
return convert_spark_dataframe_with_schema(input_feature_details, data_frame)
404+
405+
406+
def validate_model_ocid(model_ocid):
407+
pattern = r'^ocid1\.datasciencemodel\.oc(?P<realm>[0-17]+)\.(?P<region>[A-Za-z0-9]+)?\.?(?P<future_use>[A-Za-z0-9]+)?\.(?P<unique_id>[A-Za-z0-9]+)$'
408+
match = re.match(pattern, model_ocid)
409+
if match:
410+
# groups = match.groupdict()
411+
return True
412+
return False

ads/feature_store/mixin/oci_feature_store.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,19 @@
66

77
from ads.common.oci_mixin import OCIModelMixin
88
import oci.feature_store
9+
import os
910

1011

1112
class OCIFeatureStoreMixin(OCIModelMixin):
1213
@classmethod
1314
def init_client(
1415
cls, **kwargs
1516
) -> oci.feature_store.feature_store_client.FeatureStoreClient:
17+
18+
fs_service_endpoint = os.environ.get("OCI_FS_SERVICE_ENDPOINT")
19+
kwargs = {"service_endpoint": fs_service_endpoint}
20+
21+
1622
client = cls._init_client(
1723
client=oci.feature_store.feature_store_client.FeatureStoreClient, **kwargs
1824
)

0 commit comments

Comments
 (0)