Skip to content

Commit 47c1084

Browse files
committed
Updated pr.
1 parent 5406f73 commit 47c1084

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

ads/aqua/modeldeployment/entities.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ class AquaDeployment(DataClassSerializable):
5050
private_endpoint_id: str = None
5151
console_link: str = None
5252
lifecycle_details: str = None
53-
shape_info: field(default_factory=ShapeInfo) = None
53+
shape_info: Optional[ShapeInfo] = None
5454
tags: dict = None
5555
environment_variables: dict = None
5656

@@ -99,9 +99,7 @@ def from_oci_model_deployment(
9999
freeform_tags = oci_model_deployment.freeform_tags or UNKNOWN_DICT
100100
aqua_service_model_tag = freeform_tags.get(Tags.AQUA_SERVICE_MODEL_TAG, None)
101101
aqua_model_name = freeform_tags.get(Tags.AQUA_MODEL_NAME_TAG, UNKNOWN)
102-
private_endpoint_id = (
103-
getattr(oci_model_deployment.model_deployment_configuration_details.model_configuration_details.instance_configuration, "private_endpoint_id", UNKNOWN)
104-
)
102+
private_endpoint_id = getattr(instance_configuration, "private_endpoint_id", UNKNOWN)
105103

106104
return AquaDeployment(
107105
id=oci_model_deployment.id,

ads/model/deployment/model_deployment.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1652,6 +1652,7 @@ def _build_model_deployment_configuration_details(self) -> Dict:
16521652
if not hasattr(
16531653
oci.data_science.models.InstanceConfiguration, "private_endpoint_id"
16541654
):
1655+
# TODO: add oci version with private endpoint support.
16551656
raise EnvironmentError(
16561657
"Private endpoint is not supported in the current OCI SDK installed."
16571658
)

0 commit comments

Comments
 (0)