Skip to content

Commit 43974af

Browse files
committed
length of training data should be atleast twice the horizon
1 parent 3a9f815 commit 43974af

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

ads/opctl/operator/lowcode/forecast/model_evaluator.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ def __init__(self, models, k=5, subsample_ratio=0.20):
3939
def generate_cutoffs(self, unique_dates, horizon):
4040
sorted_dates = np.sort(unique_dates)
4141
train_window_size = [len(sorted_dates) - (i + 1) * horizon for i in range(self.k)]
42-
valid_train_window_size = [ws for ws in train_window_size if ws >= horizon * 3]
42+
valid_train_window_size = [ws for ws in train_window_size if ws >= horizon * 2]
4343
if len(valid_train_window_size) < self.k:
4444
logger.warn(f"Only {valid_train_window_size} backtests can be created")
4545
cut_offs = sorted_dates[-horizon - 1:-horizon * (self.k + 1):-horizon][:len(valid_train_window_size)]
@@ -97,8 +97,8 @@ def create_operator_config(self, operator_config, backtest, model, historical_da
9797
backtest_spec["historical_data"]["url"] = historical_data_url
9898
if backtest_spec["additional_data"]:
9999
backtest_spec["additional_data"]["url"] = additional_data_url
100-
if backtest_spec["test_data"]:
101-
backtest_spec["test_data"]["url"] = test_data_url
100+
backtest_spec["test_data"] = {}
101+
backtest_spec["test_data"]["url"] = test_data_url
102102
backtest_spec["model"] = model
103103
backtest_spec['model_kwargs'] = None
104104
backtest_spec["output_directory"] = {"url": output_file_path}

0 commit comments

Comments
 (0)