Skip to content

Commit 3c22785

Browse files
committed
Update test_catalog_project.py
1 parent 8b9b989 commit 3c22785

File tree

1 file changed

+31
-15
lines changed

1 file changed

+31
-15
lines changed

tests/unitary/default_setup/catalog/test_catalog_project.py

Lines changed: 31 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,23 @@
22

33
# Copyright (c) 2021, 2023 Oracle and/or its affiliates.
44
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
5-
6-
from ads.catalog.project import ProjectCatalog, ProjectSummaryList
7-
from ads.common import auth, oci_client
8-
from ads.common.utils import random_valid_ocid
9-
from ads.config import NB_SESSION_COMPARTMENT_OCID
5+
import os
6+
import unittest
107
from collections import namedtuple
118
from datetime import datetime, timezone, timedelta
12-
from oci.exceptions import ServiceError
9+
from importlib import reload
1310
from unittest import mock
1411
from unittest.mock import MagicMock, Mock, patch
12+
1513
import oci
16-
import os
1714
import pytest
18-
import unittest
15+
from oci.exceptions import ServiceError
16+
17+
import ads.config
18+
from ads.catalog.project import ProjectCatalog, ProjectSummaryList
19+
from ads.common import auth, oci_client
20+
from ads.common.utils import random_valid_ocid
21+
from ads.config import NB_SESSION_COMPARTMENT_OCID
1922

2023

2124
def generate_project_list(
@@ -62,7 +65,9 @@ class ProjectCatalogTest(unittest.TestCase):
6265
with patch.object(auth, "default_signer"):
6366
with patch.object(oci_client, "OCIClientFactory"):
6467
project_id = "ocid1.projectcatalog.oc1.iad.<unique_ocid>"
65-
comp_id = os.environ.get("NB_SESSION_COMPARTMENT_OCID", "ocid1.compartment.oc1.iad.<unique_ocid>")
68+
comp_id = os.environ.get(
69+
"NB_SESSION_COMPARTMENT_OCID", "ocid1.compartment.oc1.iad.<unique_ocid>"
70+
)
6671
date_time = datetime(2020, 7, 1, 18, 24, 42, 110000, tzinfo=timezone.utc)
6772

6873
pc = ProjectCatalog(compartment_id=comp_id)
@@ -71,8 +76,20 @@ class ProjectCatalogTest(unittest.TestCase):
7176

7277
psl = ProjectSummaryList(generate_project_list())
7378

79+
def setUp(self) -> None:
80+
os.environ[
81+
"NB_SESSION_COMPARTMENT_OCID"
82+
] = "ocid1.compartment.oc1.<unique_ocid>"
83+
reload(ads.config)
84+
return super().setUp()
85+
86+
def tearDown(self) -> None:
87+
os.environ.pop("NB_SESSION_COMPARTMENT_OCID", None)
88+
reload(ads.config)
89+
return super().tearDown()
90+
7491
@staticmethod
75-
def generate_project_response_data(self, compartment_id=None, project_id=None):
92+
def generate_project_response_data(compartment_id=None, project_id=None):
7693
entity_item = {
7794
"compartment_id": compartment_id,
7895
"created_by": "mock_user",
@@ -82,7 +99,7 @@ def generate_project_response_data(self, compartment_id=None, project_id=None):
8299
"freeform_tags": {},
83100
"id": project_id,
84101
"lifecycle_state": "ACTIVE",
85-
"time_created": self.date_time.isoformat(),
102+
"time_created": ProjectCatalogTest.date_time.isoformat(),
86103
}
87104
project_response = oci.data_science.models.Project(**entity_item)
88105
return project_response
@@ -104,7 +121,7 @@ def test_project_init_without_compartment_id(self, mock_client, mock_signer):
104121
def test_decorate_project_session_attributes(self):
105122
"""Test ProjectCatalog._decorate_project method."""
106123
project = self.generate_project_response_data(
107-
self, compartment_id=self.comp_id, project_id=self.project_id
124+
compartment_id=self.comp_id, project_id=self.project_id
108125
)
109126

110127
def generate_get_user_data(self, compartment_id=None):
@@ -160,7 +177,6 @@ def test_get_project_with_short_id(self):
160177
def mock_get_notebook_session(project_id=id):
161178
return Mock(
162179
data=self.generate_project_response_data(
163-
self,
164180
compartment_id=self.comp_id,
165181
project_id=short_id_index[short_id],
166182
)
@@ -258,7 +274,7 @@ def test_update_project_with_short_id(self):
258274
wrapper = namedtuple("wrapper", ["data"])
259275
client_update_project_response = wrapper(
260276
data=self.generate_project_response_data(
261-
self, compartment_id=self.comp_id, project_id=short_id_index[short_id]
277+
compartment_id=self.comp_id, project_id=short_id_index[short_id]
262278
)
263279
)
264280
self.pc.ds_client.update_project = MagicMock(
@@ -315,5 +331,5 @@ def test_project_summary_list_filter_invalid_param(self):
315331
# selection is a notebook session instance
316332
with pytest.raises(ValueError):
317333
self.psl.filter(
318-
selection=self.generate_project_response_data(self), instance=None
334+
selection=self.generate_project_response_data(), instance=None
319335
)

0 commit comments

Comments
 (0)