Skip to content

Commit 3b60caa

Browse files
committed
Added support for overriding defined tags in ads job run.
1 parent ec98c27 commit 3b60caa

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

ads/jobs/ads_job.py

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,14 @@ def create(self, **kwargs) -> "Job":
383383
return self
384384

385385
def run(
386-
self, name=None, args=None, env_var=None, freeform_tags=None, wait=False
386+
self,
387+
name=None,
388+
args=None,
389+
env_var=None,
390+
freeform_tags=None,
391+
defined_tags=None,
392+
wait=False,
393+
**kwargs
387394
) -> Union[DataScienceJobRun, DataFlowRun]:
388395
"""Runs the job.
389396
@@ -404,11 +411,15 @@ def run(
404411
Additional environment variables for the job run, by default None
405412
freeform_tags : dict, optional
406413
Freeform tags for the job run, by default None
414+
defined_tags : dict, optional
415+
Defined tags for the job run, by default None
407416
wait : bool, optional
408417
Indicate if this method call should wait for the job run.
409418
By default False, this method returns as soon as the job run is created.
410419
If this is set to True, this method will stream the job logs and wait until it finishes,
411420
similar to `job.run().watch()`.
421+
kwargs
422+
additional keyword arguments
412423
413424
Returns
414425
-------
@@ -423,7 +434,8 @@ def run(
423434
name="<my_job_run_name>",
424435
args="new_arg --new_key new_val",
425436
env_var={"new_env": "new_val"},
426-
freeform_tags={"new_tag": "new_tag_val"}
437+
freeform_tags={"new_tag": "new_tag_val"},
438+
defined_tags={"Operations": {"CostCenter": "42"}}
427439
)
428440
429441
"""
@@ -432,7 +444,9 @@ def run(
432444
args=args,
433445
env_var=env_var,
434446
freeform_tags=freeform_tags,
447+
defined_tags=defined_tags,
435448
wait=wait,
449+
**kwargs
436450
)
437451

438452
def run_list(self, **kwargs) -> list:

ads/jobs/builders/infrastructure/dsc_job.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1542,6 +1542,7 @@ def run(
15421542
freeform_tags=None,
15431543
defined_tags=None,
15441544
wait=False,
1545+
**kwargs
15451546
) -> DataScienceJobRun:
15461547
"""Runs a job on OCI Data Science job
15471548
@@ -1559,6 +1560,8 @@ def run(
15591560
Defined tags for the job run, by default None
15601561
wait : bool, optional
15611562
Indicate if this method should wait for the run to finish before it returns, by default False.
1563+
kwargs
1564+
additional keyword arguments
15621565
15631566
Returns
15641567
-------
@@ -1597,6 +1600,7 @@ def run(
15971600
freeform_tags=freeform_tags,
15981601
defined_tags=defined_tags,
15991602
wait=wait,
1603+
**kwargs
16001604
)
16011605

16021606
def delete(self) -> None:

0 commit comments

Comments
 (0)