Skip to content

Commit 39759b9

Browse files
authored
Reverting track md logs for error logging (#1225)
1 parent 7104fc3 commit 39759b9

File tree

4 files changed

+9
-25
lines changed

4 files changed

+9
-25
lines changed

ads/aqua/modeldeployment/deployment.py

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -769,7 +769,6 @@ def _create_deployment(
769769
logger.info(
770770
f"Aqua model deployment {deployment_id} created for model {aqua_model_id}. Work request Id is {deployment.dsc_model_deployment.workflow_req_id}"
771771
)
772-
status_list = []
773772

774773
progress_thread = threading.Thread(
775774
target=self.get_deployment_status,
@@ -1316,45 +1315,24 @@ def get_deployment_status(
13161315
poll_interval=DEFAULT_POLL_INTERVAL,
13171316
)
13181317
except Exception:
1319-
status = ""
1320-
logs = deployment.show_logs().sort_values(by="time", ascending=False)
1321-
1322-
if logs and len(logs) > 0:
1323-
status = logs.iloc[0]["message"]
1324-
1325-
status = re.sub(r"[^a-zA-Z0-9]", " ", status)
1326-
13271318
if data_science_work_request._error_message:
13281319
error_str = ""
13291320
for error in data_science_work_request._error_message:
13301321
error_str = error_str + " " + error.message
13311322

13321323
error_str = re.sub(r"[^a-zA-Z0-9]", " ", error_str)
1333-
telemetry_kwargs = {
1334-
"ocid": ocid,
1335-
"model_name": model_name,
1336-
"work_request_error": error_str,
1337-
"status": status,
1338-
}
13391324

1340-
self.telemetry.record_event(
1341-
category=f"aqua/{model_type}/deployment/status",
1342-
action="FAILED",
1343-
**telemetry_kwargs,
1344-
)
1345-
else:
13461325
telemetry_kwargs = {
13471326
"ocid": ocid,
13481327
"model_name": model_name,
1349-
"status": status,
1328+
"work_request_error": error_str,
13501329
}
13511330

13521331
self.telemetry.record_event(
13531332
category=f"aqua/{model_type}/deployment/status",
13541333
action="FAILED",
13551334
**telemetry_kwargs,
13561335
)
1357-
13581336
else:
13591337
telemetry_kwargs = {"ocid": ocid, "model_name": model_name}
13601338
self.telemetry.record_event(

docs/source/release_notes.rst

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,13 @@
22
Release Notes
33
=============
44

5+
2.13.14
6+
-------
7+
Release date: Jul 10, 2025
8+
9+
* Resolve issues with AQUA telemetry reporting
10+
11+
512
2.13.13
613
-------
714
Release date: Jul 10, 2025

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ build-backend = "flit_core.buildapi"
2121

2222
# Required
2323
name = "oracle_ads" # the install (PyPI) name; name for local build in [tool.flit.module] section below
24-
version = "2.13.13"
24+
version = "2.13.14"
2525

2626
# Optional
2727
description = "Oracle Accelerated Data Science SDK"

tests/unitary/with_extras/aqua/test_deployment.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2441,7 +2441,6 @@ def test_get_deployment_status_failed(self):
24412441
self.assertEqual(kwargs["category"], f"aqua/{model_type}/deployment/status")
24422442
self.assertEqual(kwargs["action"], "FAILED")
24432443
self.assertIn("work_request_error", kwargs)
2444-
self.assertIn("status", kwargs)
24452444
self.assertIn("ocid", kwargs)
24462445
self.assertIn("model_name", kwargs)
24472446

0 commit comments

Comments
 (0)