Skip to content

Commit 2dbe341

Browse files
committed
Use pd.concat() instead of append()
1 parent 216a364 commit 2dbe341

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

ads/feature_engineering/accessor/dataframe_accessor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ def feature_type_description(self) -> pd.DataFrame:
218218
for col in self._obj:
219219
series_feature_type_df = self._obj[col].ads.feature_type_description
220220
series_feature_type_df.insert(0, "Column", col)
221-
result_df = result_df.append(series_feature_type_df)
221+
result_df = pd.concat([result_df, series_feature_type_df])
222222
result_df.reset_index(drop=True, inplace=True)
223223
return result_df
224224

ads/feature_engineering/accessor/mixin/eda_mixin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,5 +262,5 @@ def warning(self) -> pd.DataFrame:
262262
warning_df = self._obj[col].ads.warning()
263263
if warning_df is not None:
264264
warning_df.insert(0, "Column", col)
265-
result_df = result_df.append(warning_df)
265+
result_df = pd.concat([result_df, warning_df])
266266
return result_df.reset_index(drop=True)

ads/feature_engineering/accessor/mixin/eda_mixin_series.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,6 @@ def warning(self) -> pd.DataFrame:
8080
warning_df = feature_type.warning(self._obj)
8181
if warning_df is not None:
8282
warning_df.insert(0, "Feature Type", feature_type.name)
83-
result_df = result_df.append(warning_df)
83+
result_df = pd.concat([result_df, warning_df])
8484
result_df.reset_index(drop=True, inplace=True)
8585
return result_df

ads/feature_engineering/accessor/mixin/feature_types_mixin.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,14 +115,14 @@ def warning_registered(self) -> pd.DataFrame:
115115
for col in self._obj.columns:
116116
feature_type_df = self._obj[col].ads.warning_registered()
117117
feature_type_df.insert(0, "Column", col)
118-
result_df = result_df.append(feature_type_df)
118+
result_df = pd.concat([result_df, feature_type_df])
119119
else:
120120
result_df = pd.DataFrame((), columns=common_columns)
121121
for feature_type in self._feature_type:
122122
feature_type_df = feature_type.warning.registered()
123123
feature_type_df.insert(0, "Feature Type", feature_type.name)
124124
feature_type_df = feature_type_df.rename(columns={"Name": "Warning"})
125-
result_df = result_df.append(feature_type_df)
125+
result_df = pd.concat([result_df, feature_type_df])
126126
result_df.reset_index(drop=True, inplace=True)
127127
return result_df
128128

@@ -155,14 +155,14 @@ def validator_registered(self) -> pd.DataFrame:
155155
for col in self._obj.columns:
156156
feature_type_df = self._obj[col].ads.validator_registered()
157157
feature_type_df.insert(0, "Column", col)
158-
result_df = result_df.append(feature_type_df)
158+
result_df = pd.concat([result_df, feature_type_df])
159159
else:
160160
result_df = pd.DataFrame((), columns=common_columns)
161161
for feature_type in self._feature_type:
162162
feature_type_df = feature_type.validator.registered()
163163
feature_type_df.insert(0, "Feature Type", feature_type.name)
164164
feature_type_df = feature_type_df.rename(columns={"Name": "Validator"})
165-
result_df = result_df.append(feature_type_df)
165+
result_df = pd.concat([result_df, feature_type_df])
166166
result_df.reset_index(drop=True, inplace=True)
167167
return result_df
168168

ads/feature_engineering/feature_type/handler/feature_validator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ def registered(self) -> pd.DataFrame:
261261
for key, feature_validator in self._validators.items():
262262
feature_validators_df = feature_validator.registered()
263263
feature_validators_df.insert(0, "Validator", key)
264-
result_df = result_df.append(feature_validators_df)
264+
result_df = pd.concat([result_df, feature_validators_df])
265265
result_df.reset_index(drop=True, inplace=True)
266266
return result_df
267267

ads/feature_engineering/feature_type_manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ def warning_registered(cls) -> pd.DataFrame:
371371
feature_type_df = feature_type.warning.registered()
372372
feature_type_df.insert(0, "Feature Type", feature_type.name)
373373
feature_type_df = feature_type_df.rename(columns={"Name": "Warning"})
374-
result_df = result_df.append(feature_type_df)
374+
result_df = pd.concat([result_df, feature_type_df])
375375
result_df.reset_index(drop=True, inplace=True)
376376
return result_df
377377

@@ -401,6 +401,6 @@ def validator_registered(cls) -> pd.DataFrame:
401401
feature_type_df = feature_type.validator.registered()
402402
feature_type_df.insert(0, "Feature Type", feature_type.name)
403403
feature_type_df = feature_type_df.rename(columns={"Name": "Validator"})
404-
result_df = result_df.append(feature_type_df)
404+
result_df = pd.concat([result_df, feature_type_df])
405405
result_df.reset_index(drop=True, inplace=True)
406406
return result_df

0 commit comments

Comments
 (0)