Skip to content

Commit 1baf8a1

Browse files
committed
Updated pr.
1 parent d2d7182 commit 1baf8a1

File tree

2 files changed

+35
-30
lines changed

2 files changed

+35
-30
lines changed

ads/common/oci_mixin.py

Lines changed: 22 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
from enum import Enum
2020

2121
import oci
22-
import tqdm
22+
from tqdm import tqdm
2323
import yaml
2424
from ads.common import auth
2525
from ads.common.decorator.utils import class_or_instance_method
@@ -1051,17 +1051,14 @@ def __init__(self, id: str, description: str = "Processing"):
10511051
self._status = None
10521052

10531053
def _sync(self):
1054-
try:
1055-
work_request = self.client.get_work_request(self.id).data
1056-
work_request_logs = self.client.list_work_request_logs(
1057-
self.id
1058-
).data
1054+
work_request = self.client.get_work_request(self.id).data
1055+
work_request_logs = self.client.list_work_request_logs(
1056+
self.id
1057+
).data
10591058

1060-
self._percentage= work_request.percent_complete
1061-
self._status = work_request.status
1062-
self._description = work_request_logs[:-1]
1063-
except Exception as ex:
1064-
logger.warn(ex)
1059+
self._percentage= work_request.percent_complete
1060+
self._status = work_request.status
1061+
self._description = work_request_logs[:-1]
10651062

10661063
def watch(
10671064
self,
@@ -1081,14 +1078,17 @@ def watch(
10811078
return
10821079

10831080
time.sleep(poll_interval)
1084-
self._sync()
1081+
1082+
try:
1083+
self._sync()
1084+
except Exception as ex:
1085+
logger.warn(ex)
1086+
continue
1087+
10851088
percent_change = self._percentage - previous_percent_complete
10861089
previous_percent_complete = self._percentage
10871090
description = self._description if previous_log != self._description else ""
1088-
progress_callback(
1089-
percent_change=percent_change,
1090-
description=description
1091-
)
1091+
progress_callback(percent_change, description)
10921092
previous_log = self._description
10931093

10941094
if self._status in WORK_REQUEST_STOP_STATE:
@@ -1103,21 +1103,22 @@ def watch(
11031103
else:
11041104
break
11051105

1106-
progress_callback(percent_change=0, description="Done")
1106+
progress_callback(0, "Done")
11071107

11081108

11091109
def wait_work_request(
11101110
id: str,
1111-
desc: str,
1111+
progress_bar_description: str,
11121112
max_wait_time: int=DEFAULT_WAIT_TIME,
11131113
poll_interval: int=DEFAULT_POLL_INTERVAL
11141114
):
11151115
ads_work_request = ADSWorkRequest(id)
11161116

11171117
with tqdm(
11181118
leave=False,
1119+
mininterval=0,
11191120
file=sys.stdout,
1120-
desc=desc,
1121+
desc=progress_bar_description,
11211122
) as pbar:
11221123

11231124
def progress_callback(percent_change, description):
@@ -1128,7 +1129,7 @@ def progress_callback(percent_change, description):
11281129

11291130
ads_work_request.watch(
11301131
progress_callback,
1131-
max_wait_time=max_wait_time,
1132-
poll_interval=poll_interval
1132+
max_wait_time,
1133+
poll_interval
11331134
)
11341135

ads/model/service/oci_datascience_model_deployment.py

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import logging
99
from typing import Callable, List
1010
from ads.common.oci_datascience import OCIDataScienceMixin
11-
from ads.common.oci_mixin import OCIWorkRequestMixin
11+
from ads.common.oci_mixin import OCIWorkRequestMixin, wait_work_request
1212
from ads.config import PROJECT_OCID
1313
from ads.model.deployment.common.utils import OCIClientManager, State
1414
import oci
@@ -197,8 +197,9 @@ def activate(
197197
self.workflow_req_id = response.headers.get("opc-work-request-id", None)
198198

199199
try:
200-
self.wait_for_progress(
201-
self.workflow_req_id,
200+
wait_work_request(
201+
self.workflow_req_id,
202+
f"Activating model deployment: {self.display_name}",
202203
max_wait_time,
203204
poll_interval
204205
)
@@ -247,8 +248,9 @@ def create(
247248
self.workflow_req_id = response.headers.get("opc-work-request-id", None)
248249

249250
try:
250-
self.wait_for_progress(
251-
self.workflow_req_id,
251+
wait_work_request(
252+
self.workflow_req_id,
253+
f"Creating model deployment: {self.display_name}",
252254
max_wait_time,
253255
poll_interval
254256
)
@@ -309,8 +311,9 @@ def deactivate(
309311
self.workflow_req_id = response.headers.get("opc-work-request-id", None)
310312

311313
try:
312-
self.wait_for_progress(
313-
self.workflow_req_id,
314+
wait_work_request(
315+
self.workflow_req_id,
316+
f"Deactivating model deployment: {self.display_name}",
314317
max_wait_time,
315318
poll_interval
316319
)
@@ -378,8 +381,9 @@ def delete(
378381
self.workflow_req_id = response.headers.get("opc-work-request-id", None)
379382

380383
try:
381-
self.wait_for_progress(
382-
self.workflow_req_id,
384+
wait_work_request(
385+
self.workflow_req_id,
386+
f"Deleting model deployment: {self.display_name}",
383387
max_wait_time,
384388
poll_interval
385389
)

0 commit comments

Comments
 (0)