Skip to content

Commit 1660770

Browse files
authored
Fixed generic model multiple deploy. (#309)
2 parents 15c447e + f745535 commit 1660770

File tree

1 file changed

+14
-6
lines changed

1 file changed

+14
-6
lines changed

ads/model/generic_model.py

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2151,7 +2151,7 @@ def deploy(
21512151
"log_id", None
21522152
)
21532153
or self.properties.deployment_predict_log_id,
2154-
deployment_image = existing_runtime.image
2154+
deployment_image = getattr(existing_runtime, "image", None)
21552155
or self.properties.deployment_image,
21562156
deployment_instance_subnet_id = existing_infrastructure.subnet_id
21572157
or self.properties.deployment_instance_subnet_id
@@ -2229,16 +2229,24 @@ def deploy(
22292229
runtime = None
22302230
if self.properties.deployment_image:
22312231
image_digest = (
2232-
kwargs.pop("image_digest", None) or existing_runtime.image_digest
2232+
kwargs.pop("image_digest", None)
2233+
or getattr(existing_runtime, "image_digest", None)
2234+
)
2235+
cmd = (
2236+
kwargs.pop("cmd", [])
2237+
or getattr(existing_runtime, "cmd", [])
2238+
)
2239+
entrypoint = (
2240+
kwargs.pop("entrypoint", [])
2241+
or getattr(existing_runtime, "entrypoint", [])
22332242
)
2234-
cmd = kwargs.pop("cmd", []) or existing_runtime.cmd
2235-
entrypoint = kwargs.pop("entrypoint", []) or existing_runtime.entrypoint
22362243
server_port = (
2237-
kwargs.pop("server_port", None) or existing_runtime.server_port
2244+
kwargs.pop("server_port", None)
2245+
or getattr(existing_runtime, "server_port", None)
22382246
)
22392247
health_check_port = (
22402248
kwargs.pop("health_check_port", None)
2241-
or existing_runtime.health_check_port
2249+
or getattr(existing_runtime, "health_check_port", None)
22422250
)
22432251
runtime = (
22442252
ModelDeploymentContainerRuntime()

0 commit comments

Comments
 (0)