Skip to content

Commit a8ee653

Browse files
committed
cluster autoscaler clean up
Signed-off-by: junior <junior@users.noreply.github.com>
1 parent 0e71f1f commit a8ee653

File tree

2 files changed

+13
-16
lines changed

2 files changed

+13
-16
lines changed

modules/oke-cluster-autoscaler/main.tf

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,23 +3,20 @@
33
#
44

55
locals {
6-
cluster_autoscaler_supported_k8s_versions = { "1.21" = "1.21.1-3", "1.22" = "1.22.2-4", "1.23" = "1.23.0-4" } # There's no API to get that list. Need to be updated manually
7-
cluster_autoscaler_image_version = lookup(local.cluster_autoscaler_supported_k8s_versions, local.k8s_major_minor_version, reverse(values(local.cluster_autoscaler_supported_k8s_versions))[0])
8-
cluster_autoscaler_default_region = "us-ashburn-1"
9-
cluster_autoscaler_image_regions = ["us-ashburn-1", "us-phoenix-1", "uk-london-1", "eu-frankfurt-1"]
10-
cluster_autoscaler_image_region = contains(local.cluster_autoscaler_image_regions, var.region) ? var.region : local.cluster_autoscaler_default_region
11-
cluster_autoscaler_image = "${local.cluster_autoscaler_image_region}.ocir.io/oracle/oci-cluster-autoscaler:${local.cluster_autoscaler_image_version}"
12-
cluster_autoscaler_log_level_verbosity = 4
13-
cluster_autoscaler_node_pools = [for map in var.oke_node_pools[*] : "--nodes=${map.node_pool_min_nodes}:${map.node_pool__max_nodes}:${map.node_pool_id}"]
14-
# cluster_autoscaler_node_pool = var.create_new_oke_cluster ? oci_containerengine_node_pool.oke_node_pool[0].id : var.existent_oke_nodepool_id_for_autoscaler
15-
# cluster_autoscaler_min_nodes = var.cluster_autoscaler_min_nodes
16-
# cluster_autoscaler_max_nodes = var.cluster_autoscaler_max_nodes
6+
cluster_autoscaler_supported_k8s_versions = { "1.21" = "1.21.1-3", "1.22" = "1.22.2-4", "1.23" = "1.23.0-4" } # There's no API to get that list. Need to be updated manually
7+
cluster_autoscaler_image_version = lookup(local.cluster_autoscaler_supported_k8s_versions, local.k8s_major_minor_version, reverse(values(local.cluster_autoscaler_supported_k8s_versions))[0])
8+
cluster_autoscaler_default_region = "us-ashburn-1"
9+
cluster_autoscaler_image_regions = ["us-ashburn-1", "us-phoenix-1", "uk-london-1", "eu-frankfurt-1"]
10+
cluster_autoscaler_image_region = contains(local.cluster_autoscaler_image_regions, var.region) ? var.region : local.cluster_autoscaler_default_region
11+
cluster_autoscaler_image = "${local.cluster_autoscaler_image_region}.ocir.io/oracle/oci-cluster-autoscaler:${local.cluster_autoscaler_image_version}"
12+
cluster_autoscaler_log_level_verbosity = 4
13+
cluster_autoscaler_node_pools = [for map in var.oke_node_pools[*] : "--nodes=${map.node_pool_min_nodes}:${map.node_pool_max_nodes}:${map.node_pool_id}"]
1714
cluster_autoscaler_max_node_provision_time = "25m"
1815
cluster_autoscaler_scale_down_delay_after_add = "10m"
1916
cluster_autoscaler_scale_down_unneeded_time = "10m"
2017
cluster_autoscaler_unremovable_node_recheck_timeout = "5m"
2118
cluster_autoscaler_enabled = alltrue([contains(keys(local.cluster_autoscaler_supported_k8s_versions), local.k8s_major_minor_version)]) ? var.cluster_autoscaler_enabled : false
22-
k8s_major_minor_version = regex("\\d+(?:\\.(?:\\d+|x)(?:))", (var.k8s_version == "Latest") ? local.node_pool_k8s_latest_version : var.k8s_version)
19+
k8s_major_minor_version = regex("\\d+(?:\\.(?:\\d+|x)(?:))", var.oke_node_pools.0.node_k8s_version)
2320
}
2421

2522
# NOTE: Service Account creation is not supported with Kubernetes 1.24 and Terraform Kubernetes provider 2.12.1.

modules/oke-cluster-autoscaler/variables.tf

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ variable "oke_node_pools" {
2424
default = []
2525
description = "Node pools (id, min_nodes, max_nodes) to use with Cluster Autoscaler"
2626
}
27-
variable "k8s_version" {
28-
default = "Latest"
29-
description = "Kubernetes version installed on your worker nodes"
30-
}
27+
# variable "k8s_version" {
28+
# default = "Latest"
29+
# description = "Kubernetes version installed on your worker nodes"
30+
# }
3131

3232
# OCI Provider
3333
variable "region" {}

0 commit comments

Comments
 (0)