Skip to content

Commit dc24a5a

Browse files
authored
Merge pull request #1137 from optuna/feat/unit-test-for-useEvalTrialFilter
Implement unit tests for `useEvalTrialFilter` hook
2 parents 9ddfd47 + ea543a3 commit dc24a5a

File tree

9 files changed

+449
-34
lines changed

9 files changed

+449
-34
lines changed

.github/workflows/typescript-tests.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,11 @@ jobs:
203203
run: |
204204
npm run test
205205
206+
- name: Install Playwright Browsers
207+
working-directory: tslib/react
208+
run: |
209+
npx playwright install --with-deps
210+
206211
- name: Run tslib test for react
207212
working-directory: tslib/react
208213
run: |

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ rustlib/pkg/
3434
.coverage.*
3535
coverage.xml
3636
tslib/storage/test/asset/
37+
tslib/react/test/browser/__screenshots__
3738

3839
# Others
3940
.envrc

CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ $ OPTUNA_DASHBOARD_DEBUG=1 optuna-dashboard sqlite:///db.sqlite3
102102
#### Running unit tests for `tslib/`
103103

104104
```
105+
$ npx playwright install --with-deps
105106
$ make tslib-test
106107
```
107108

optuna_dashboard/package-lock.json

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

standalone_app/package-lock.json

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)