Merge pull request #1161 from c-bata/avoid-exporting-page-id

Refactor AppDrawer: avoid exporting PageId type

Author: c-bata

optuna_dashboard/ts/components/AppDrawer.tsx

@@ -53,16 +53,6 @@ import { useConstants } from "../constantsProvider"
 
 const drawerWidth = 240
 
-export type PageId =
-  | "top"
-  | "analytics"
-  | "trialTable"
-  | "trialList"
-  | "trialSelection"
-  | "note"
-  | "preferenceHistory"
-  | "graph"
-
 const openedMixin = (theme: Theme): CSSObject => ({
   width: drawerWidth,
   transition: theme.transitions.create("width", {

optuna_dashboard/ts/components/StudyDetail.tsx

@@ -15,7 +15,7 @@ import { Link, useParams } from "react-router-dom"
 import { useConstants } from "../constantsProvider"
 import { useLatestStudyDetail } from "../hooks/useLatestStudyDetail"
 import { useStudyIsPreferential, useStudyName } from "../state"
-import { AppDrawer, PageId } from "./AppDrawer"
+import { AppDrawer } from "./AppDrawer"
 import { Contour } from "./GraphContour"
 import { GraphEdf } from "./GraphEdf"
 import { GraphParallelCoordinate } from "./GraphParallelCoordinate"
@@ -31,6 +31,16 @@ import { TrialList } from "./TrialList"
 import { TrialSelection } from "./TrialSelection"
 import { TrialTable } from "./TrialTable"
 
+type PageId =
+  | "top"
+  | "analytics"
+  | "trialTable"
+  | "trialList"
+  | "trialSelection"
+  | "note"
+  | "preferenceHistory"
+  | "graph"
+
 export const useURLVars = (): number => {
   const { studyId } = useParams<{ studyId: string }>()