Skip to content

Commit f7dc14a

Browse files
seems to be failing unit tests?
2 parents 8b0d21b + eccabb5 commit f7dc14a

File tree

145 files changed

+2555
-1298
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

145 files changed

+2555
-1298
lines changed

CHANGELOG.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# Optimizely Swift SDK Changelog
2+
3+
## 3.1.0-RC
4+
Date
5+
6+
This the initial release of the Swift SDK. It is a pure Swift implementation take complete advantage of language features and performance. It supports objective-C as well through objective-c only API. It uses Swift 4.2 but we will be upgrading to 5.0 soon.
7+
8+
This modernized version of the SDK is meant to replace the Objective-C SDK.
9+
10+
### New Features
11+
* No new features for this release. It supports all of the 3.1 features in all of Optimizély's SDKs.
12+
13+
### Bug Fixes:
14+
* Change all instances of attributes and eventTags from NSDictionary<NSString*,NSObject*> to NSDictionary<NSString*,id>
15+
16+
### Breaking Changes
17+

CONTRIBUTING.md

Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
# Contributing to the Optimizely Swift SDK
2+
3+
We welcome contributions and feedback! All contributors must sign our [Contributor License Agreement (CLA)](https://docs.google.com/a/optimizely.com/forms/d/e/1FAIpQLSf9cbouWptIpMgukAKZZOIAhafvjFCV8hS00XJLWQnWDFtwtA/viewform) to be eligible to contribute. Please read the [README](README.md) to set up your development environment, then read the guidelines below for information on submitting your code.
4+
5+
## Development process
6+
7+
1. Create a branch off of `master`: `git checkout -b YOUR_NAME/branch_name`.
8+
2. Commit your changes. We follow the [commit message guidelines](https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines) from Angular.
9+
3. Make sure to add tests!
10+
4. Run Swift linter (TBD).
11+
5. `git push` your changes to GitHub.
12+
6. Make sure that all unit tests are passing and that there are no merge conflicts between your branch and `master`.
13+
7. Open a pull request from `YOUR_NAME/branch_name` to `master`.
14+
8. A repository maintainer will review your pull request and, if all goes well, squash and merge it!
15+
16+
## Pull request acceptance criteria
17+
18+
* **All code must have test coverage.** We use unittest. Changes in functionality should have accompanying unit tests. Bug fixes should have accompanying regression tests.
19+
* Tests are located in each module with one file per class.
20+
* Please don't change the SDK Version. We'll take care of bumping the version when we next release.
21+
22+
## Style
23+
24+
We follow the [Ray Wenderlich style guide](https://github.com/raywenderlich/swift-style-guide) since they have put a lot of thought into making their code more legible. While we aim for our Optimizely SDK to be performant and bug free, we also want all customers and third party developers read and understand our code easily.
25+
26+
## License
27+
28+
All contributions are under the CLA mentioned above. For this project, Optimizely uses the Apache 2.0 license, and so asks that by contributing your code, you agree to license your contribution under the terms of the [Apache License v2.0](http://www.apache.org/licenses/LICENSE-2.0). Your contributions should also include the following header:
29+
30+
```
31+
/****************************************************************************
32+
* Copyright YEAR, Optimizely, Inc. and contributors *
33+
* *
34+
* Licensed under the Apache License, Version 2.0 (the "License"); *
35+
* you may not use this file except in compliance with the License. *
36+
* You may obtain a copy of the License at *
37+
* *
38+
* http://www.apache.org/licenses/LICENSE-2.0 *
39+
* *
40+
* Unless required by applicable law or agreed to in writing, software *
41+
* distributed under the License is distributed on an "AS IS" BASIS, *
42+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. *
43+
* See the License for the specific language governing permissions and *
44+
* limitations under the License. *
45+
***************************************************************************/
46+
```
47+
48+
The YEAR above should be the year of the contribution. If work on the file has been done over multiple years, list each year in the section above. Example: Optimizely writes the file and releases it in 2014. No changes are made in 2015. Change made in 2016. YEAR should be “2014, 2016”.
49+
50+
## Contact
51+
52+
If you have questions, please contact developers@optimizely.com.

DemoObjCApp/AppDelegate.h

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
1-
//
2-
// AppDelegate.h
3-
// DemoObjcApp
4-
//
5-
// Created by Jae Kim on 1/7/19.
6-
// Copyright © 2019 Optimizely. All rights reserved.
7-
//
1+
/****************************************************************************
2+
* Copyright 2019, Optimizely, Inc. and contributors *
3+
* *
4+
* Licensed under the Apache License, Version 2.0 (the "License"); *
5+
* you may not use this file except in compliance with the License. *
6+
* You may obtain a copy of the License at *
7+
* *
8+
* http://www.apache.org/licenses/LICENSE-2.0 *
9+
* *
10+
* Unless required by applicable law or agreed to in writing, software *
11+
* distributed under the License is distributed on an "AS IS" BASIS, *
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. *
13+
* See the License for the specific language governing permissions and *
14+
* limitations under the License. *
15+
***************************************************************************/
816

917
#import <UIKit/UIKit.h>
1018

DemoObjCApp/AppDelegate.m

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
1-
//
2-
// AppDelegate.m
3-
// DemoObjcApp
4-
//
5-
// Created by Jae Kim on 1/7/19.
6-
// Copyright © 2019 Optimizely. All rights reserved.
7-
//
1+
/****************************************************************************
2+
* Copyright 2019, Optimizely, Inc. and contributors *
3+
* *
4+
* Licensed under the Apache License, Version 2.0 (the "License"); *
5+
* you may not use this file except in compliance with the License. *
6+
* You may obtain a copy of the License at *
7+
* *
8+
* http://www.apache.org/licenses/LICENSE-2.0 *
9+
* *
10+
* Unless required by applicable law or agreed to in writing, software *
11+
* distributed under the License is distributed on an "AS IS" BASIS, *
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. *
13+
* See the License for the specific language governing permissions and *
14+
* limitations under the License. *
15+
***************************************************************************/
816

917
#import "AppDelegate.h"
1018
#import "VariationViewController.h"

DemoObjCApp/Customization/CustomLogger.h

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
1-
//
2-
// CustomLogger.h
3-
// DemoObjcApp
4-
//
5-
// Created by Jae Kim on 1/15/19.
6-
// Copyright © 2019 Optimizely. All rights reserved.
7-
//
1+
/****************************************************************************
2+
* Copyright 2019, Optimizely, Inc. and contributors *
3+
* *
4+
* Licensed under the Apache License, Version 2.0 (the "License"); *
5+
* you may not use this file except in compliance with the License. *
6+
* You may obtain a copy of the License at *
7+
* *
8+
* http://www.apache.org/licenses/LICENSE-2.0 *
9+
* *
10+
* Unless required by applicable law or agreed to in writing, software *
11+
* distributed under the License is distributed on an "AS IS" BASIS, *
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. *
13+
* See the License for the specific language governing permissions and *
14+
* limitations under the License. *
15+
***************************************************************************/
816

917
#import <Foundation/Foundation.h>
1018

DemoObjCApp/Customization/CustomLogger.m

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
1-
//
2-
// CustomLogger.m
3-
// DemoObjcApp
4-
//
5-
// Created by Jae Kim on 1/15/19.
6-
// Copyright © 2019 Optimizely. All rights reserved.
7-
//
1+
/****************************************************************************
2+
* Copyright 2019, Optimizely, Inc. and contributors *
3+
* *
4+
* Licensed under the Apache License, Version 2.0 (the "License"); *
5+
* you may not use this file except in compliance with the License. *
6+
* You may obtain a copy of the License at *
7+
* *
8+
* http://www.apache.org/licenses/LICENSE-2.0 *
9+
* *
10+
* Unless required by applicable law or agreed to in writing, software *
11+
* distributed under the License is distributed on an "AS IS" BASIS, *
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. *
13+
* See the License for the specific language governing permissions and *
14+
* limitations under the License. *
15+
***************************************************************************/
816

917
#import "CustomLogger.h"
1018
@import Optimizely;

DemoObjCApp/Customization/CustomNotificationCenter.h

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
1-
//
2-
// CustomNotificationCenter.h
3-
// DemoObjcApp
4-
//
5-
// Created by Jae Kim on 1/15/19.
6-
// Copyright © 2019 Optimizely. All rights reserved.
7-
//
1+
/****************************************************************************
2+
* Copyright 2019, Optimizely, Inc. and contributors *
3+
* *
4+
* Licensed under the Apache License, Version 2.0 (the "License"); *
5+
* you may not use this file except in compliance with the License. *
6+
* You may obtain a copy of the License at *
7+
* *
8+
* http://www.apache.org/licenses/LICENSE-2.0 *
9+
* *
10+
* Unless required by applicable law or agreed to in writing, software *
11+
* distributed under the License is distributed on an "AS IS" BASIS, *
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. *
13+
* See the License for the specific language governing permissions and *
14+
* limitations under the License. *
15+
***************************************************************************/
816

917
#import <Foundation/Foundation.h>
1018

DemoObjCApp/Customization/CustomNotificationCenter.m

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
1-
//
2-
// CustomNotificationCenter.m
3-
// DemoObjcApp
4-
//
5-
// Created by Jae Kim on 1/15/19.
6-
// Copyright © 2019 Optimizely. All rights reserved.
7-
//
1+
/****************************************************************************
2+
* Copyright 2019, Optimizely, Inc. and contributors *
3+
* *
4+
* Licensed under the Apache License, Version 2.0 (the "License"); *
5+
* you may not use this file except in compliance with the License. *
6+
* You may obtain a copy of the License at *
7+
* *
8+
* http://www.apache.org/licenses/LICENSE-2.0 *
9+
* *
10+
* Unless required by applicable law or agreed to in writing, software *
11+
* distributed under the License is distributed on an "AS IS" BASIS, *
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. *
13+
* See the License for the specific language governing permissions and *
14+
* limitations under the License. *
15+
***************************************************************************/
816

917
#import "CustomNotificationCenter.h"
1018
@import Optimizely;

DemoObjCApp/FailureViewController.h

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
1-
//
2-
// FailureViewController.h
3-
// DemoObjcApp
4-
//
5-
// Created by Jae Kim on 1/14/19.
6-
// Copyright © 2019 Optimizely. All rights reserved.
7-
//
1+
/****************************************************************************
2+
* Copyright 2019, Optimizely, Inc. and contributors *
3+
* *
4+
* Licensed under the Apache License, Version 2.0 (the "License"); *
5+
* you may not use this file except in compliance with the License. *
6+
* You may obtain a copy of the License at *
7+
* *
8+
* http://www.apache.org/licenses/LICENSE-2.0 *
9+
* *
10+
* Unless required by applicable law or agreed to in writing, software *
11+
* distributed under the License is distributed on an "AS IS" BASIS, *
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. *
13+
* See the License for the specific language governing permissions and *
14+
* limitations under the License. *
15+
***************************************************************************/
816

917
#import <UIKit/UIKit.h>
1018

DemoObjCApp/FailureViewController.m

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
1-
//
2-
// FailureViewController.m
3-
// DemoObjcApp
4-
//
5-
// Created by Jae Kim on 1/14/19.
6-
// Copyright © 2019 Optimizely. All rights reserved.
7-
//
1+
/****************************************************************************
2+
* Copyright 2019, Optimizely, Inc. and contributors *
3+
* *
4+
* Licensed under the Apache License, Version 2.0 (the "License"); *
5+
* you may not use this file except in compliance with the License. *
6+
* You may obtain a copy of the License at *
7+
* *
8+
* http://www.apache.org/licenses/LICENSE-2.0 *
9+
* *
10+
* Unless required by applicable law or agreed to in writing, software *
11+
* distributed under the License is distributed on an "AS IS" BASIS, *
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. *
13+
* See the License for the specific language governing permissions and *
14+
* limitations under the License. *
15+
***************************************************************************/
816

917
#import "FailureViewController.h"
1018

0 commit comments

Comments
 (0)