CMAB not supported in sync mode

Author: muzahidul-opti

Sources/Implementation/DefaultDecisionService.swift

@@ -87,13 +87,21 @@ class DefaultDecisionService: OPTDecisionService {
                                               experiment: Experiment,
                                               user: OptimizelyUserContext,
                                               bucketingId: String,
+                                              opType: OPType,
                                               options: [OptimizelyDecideOption]?) -> DecisionResponse<VariationDecision> {
         let reasons = DecisionReasons(options: options)
         guard let cmab = experiment.cmab else {
             logger.e("The experiment isn't a CMAB experiment")
             return DecisionResponse(result: nil, reasons: reasons)
         }
 
+        guard opType == .async else {
+            let info = LogMessage.cmabNotSupportedInSyncMode
+            logger.w(info)
+            reasons.addInfo(info)
+            return DecisionResponse(result: nil, reasons: reasons)
+        }
+        
         let dummyEntityId = "$"
         let cmabTrafficAllocation = TrafficAllocation(entityId: dummyEntityId, endOfRange: cmab.trafficAllocation)
         let group = config.getGroup(id: experiment.id)
@@ -260,13 +268,11 @@ class DefaultDecisionService: OPTDecisionService {
             let bucketingId = getBucketingId(userId: userId, attributes: attributes)
 
             if experiment.isCmab {
-                if opType == .sync {
-                    /// fixme
-                }
                 let cmabDecisionResponse = getDecisionForCmabExperiment(config: config,
                                                                         experiment: experiment,
                                                                         user: user,
                                                                         bucketingId: bucketingId,
+                                                                        opType: opType,
                                                                         options: options)
                 reasons.merge(cmabDecisionResponse.reasons)
                 variationDecision = cmabDecisionResponse.result

Sources/Utils/LogMessage.swift

@@ -76,6 +76,7 @@ enum LogMessage {
     case valueForKeyNotFound(_ key: String)
     case lowPeriodicDownloadInterval
     case cmabFetchFailed(_ expKey: String)
+    case cmabNotSupportedInSyncMode
 }
 
 extension LogMessage: CustomStringConvertible {
@@ -146,6 +147,7 @@ extension LogMessage: CustomStringConvertible {
         case .valueForKeyNotFound(let key):                                     message = "Value for JSON key (\(key)) not found."
         case .lowPeriodicDownloadInterval:                                      message = "Polling intervals below 30 seconds are not recommended."
         case .cmabFetchFailed(let key):                                         message = "Failed to fetch CMAB data for experiment: \(key)"
+        case .cmabNotSupportedInSyncMode:                                       message = "CMAB is not supported in sync mode."
         }
 
         return message