Skip to content

Commit b337b35

Browse files
wip: address review request
1 parent 7bad66d commit b337b35

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

Sources/Data Model/FeatureFlag.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,14 @@ struct FeatureFlag: Codable, Equatable, OptimizelyFeature {
3535
case variables
3636
}
3737

38+
var holdoutIds: [String] = []
39+
3840
// MARK: - OptimizelyConfig
3941

4042
var experimentsMap: [String: OptimizelyExperiment] = [:]
4143
var variablesMap: [String: OptimizelyVariable] = [:]
4244
var experimentRules: [OptimizelyExperiment] = []
4345
var deliveryRules: [OptimizelyExperiment] = []
44-
var holdoutIds: [String] = []
4546
}
4647

4748
// MARK: - Utils

Sources/Data Model/Project.swift

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,7 @@ struct Project: Codable, Equatable {
5757
// V3
5858
case anonymizeIP
5959
// V4
60-
case rollouts, integrations, typedAudiences, featureFlags, botFiltering, sendFlagDecisions, sdkKey, environmentKey
61-
// holdouts
62-
case holdouts
60+
case rollouts, integrations, typedAudiences, featureFlags, botFiltering, sendFlagDecisions, sdkKey, environmentKey, holdouts
6361
}
6462

6563
init(from decoder: Decoder) throws {
@@ -88,7 +86,6 @@ struct Project: Codable, Equatable {
8886
sendFlagDecisions = try container.decodeIfPresent(Bool.self, forKey: .sendFlagDecisions)
8987
sdkKey = try container.decodeIfPresent(String.self, forKey: .sdkKey)
9088
environmentKey = try container.decodeIfPresent(String.self, forKey: .environmentKey)
91-
9289
// Holdouts - defaults to empty array if key is not present
9390
holdouts = try container.decodeIfPresent([Holdout].self, forKey: .holdouts) ?? []
9491
}

Sources/Data Model/ProjectConfig.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,9 @@ class ProjectConfig {
8282
return map
8383
}()
8484

85-
assignHoldoutIdsToFeatureFlags()
85+
if !project.holdouts.isEmpty {
86+
assignHoldoutIdsToFeatureFlags()
87+
}
8688

8789
self.experimentKeyMap = {
8890
var map = [String: Experiment]()

0 commit comments

Comments
 (0)