Skip to content

Commit ae71cbf

Browse files
wip: update test case
1 parent 95d71c7 commit ae71cbf

File tree

2 files changed

+17
-10
lines changed

2 files changed

+17
-10
lines changed

Sources/Optimizely/OptimizelyClient.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,11 @@ open class OptimizelyClient: NSObject {
9696
self.vuidManager.configure(enable: self.sdkSettings.enableVuid)
9797
self.odpManager = odpManager ?? OdpManager(sdkKey: sdkKey,
9898
disable: sdkSettings.disableOdp,
99-
vuid: vuidManager.vuid,
10099
cacheSize: sdkSettings.segmentsCacheSize,
101100
cacheTimeoutInSecs: sdkSettings.segmentsCacheTimeoutInSecs,
102101
timeoutForSegmentFetchInSecs: sdkSettings.timeoutForSegmentFetchInSecs,
103102
timeoutForEventDispatchInSecs: sdkSettings.timeoutForOdpEventInSecs)
103+
self.odpManager.vuid = VuidManager.shared.vuid
104104

105105
let userProfileService = userProfileService ?? DefaultUserProfileService()
106106
let logger = logger ?? DefaultLogger()

Tests/OptimizelyTests-Common/OptimizelyUserContextTests_ODP_2.swift

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,21 +26,28 @@ class OptimizelyUserContextTests_ODP_2: XCTestCase {
2626

2727
// odp disabled to avoid initial noise
2828

29-
let optimizely = OptimizelyClient(sdkKey: sdkKey,
30-
settings: OptimizelySdkSettings(disableOdp: true, enableVuid: true))
3129

3230
// override with a custom enabled odpManager.
3331
// - client_inializatied event will be sent automatically
3432
// - will wait in the queue until project config is ready
3533

3634
let odpEventApiManager = MockOdpEventApiManager()
37-
optimizely.odpManager = OdpManager(sdkKey: sdkKey,
38-
disable: false,
39-
vuid: "vuid_123",
40-
cacheSize: 10,
41-
cacheTimeoutInSecs: 10,
42-
eventManager: OdpEventManager(sdkKey: sdkKey,
43-
apiManager: odpEventApiManager))
35+
// optimizely.odpManager = OdpManager(sdkKey: sdkKey,
36+
// disable: false,
37+
// vuid: "vuid_123",
38+
// cacheSize: 10,
39+
// cacheTimeoutInSecs: 10,
40+
// eventManager: OdpEventManager(sdkKey: sdkKey,
41+
// apiManager: odpEventApiManager))
42+
let optimizely = OptimizelyClient(sdkKey: sdkKey,
43+
odpManager: OdpManager(sdkKey: sdkKey,
44+
disable: false,
45+
vuid: "vuid_123",
46+
cacheSize: 10,
47+
cacheTimeoutInSecs: 10,
48+
eventManager: OdpEventManager(sdkKey: sdkKey,
49+
apiManager: odpEventApiManager)), settings: OptimizelySdkSettings(disableOdp: true, enableVuid: true))
50+
4451

4552
// identified event will sent but wait in the queue until project config is ready
4653
_ = optimizely.createUserContext(userId: "tester")

0 commit comments

Comments
 (0)