make bucketer internal to decision service

Author: thomaszurkan-optimizely

OptimizelySDK/Implementation/DefaultDecisionService.swift

@@ -21,8 +21,8 @@ class DefaultDecisionService : OPTDecisionService {
     let bucketer:OPTBucketer
     let userProfileService:OPTUserProfileService
 
-    init(bucketer: OPTBucketer, userProfileService:OPTUserProfileService) {
-        self.bucketer = bucketer
+    init(userProfileService:OPTUserProfileService) {
+        self.bucketer = DefaultBucketer()
         self.userProfileService = userProfileService
     }
 

OptimizelySDK/Optimizely/OptimizelyManager.swift

@@ -72,13 +72,12 @@ open class OptimizelyManager: NSObject {
 
         super.init()
 
-        let bucketer = DefaultBucketer()
         let userProfileService = userProfileService ?? DefaultUserProfileService()
         self.registerServices(sdkKey: sdkKey,
                               logger: logger ?? DefaultLogger(),
                               eventDispatcher: eventDispatcher ?? DefaultEventDispatcher.sharedInstance,
                               datafileHandler: DefaultDatafileHandler(),
-                              decisionService: DefaultDecisionService(bucketer: bucketer, userProfileService: userProfileService),
+                              decisionService: DefaultDecisionService(userProfileService: userProfileService),
                               notificationCenter: DefaultNotificationCenter())
 
     }

OptimizelySDK/OptimizelyTests/OptimizelyTests-Common/DecisionServiceTest.swift

@@ -26,8 +26,7 @@ class DecisionServiceTest: XCTestCase {
             return
         }
 
-        let bucketer = DefaultBucketer()
-        let decisionService = DefaultDecisionService(bucketer: bucketer, userProfileService: DefaultUserProfileService())
+        let decisionService = DefaultDecisionService(userProfileService: DefaultUserProfileService())
 
         let experiment = config.project.experiments.filter({$0.key == "typed_audience_experiment"}).first
         let attr = ["integerKey":1, "doubleKey": 99.0, "booleanKey": true, "nationality":"English"] as [String : Any]

OptimizelySDK/OptimizelyTests/OptimizelyTests-Common/DefaultUserProfileServiceTests.swift

@@ -42,7 +42,7 @@ class DefaultUserProfileServiceTests: XCTestCase {
         ups = DefaultUserProfileService()
         ups.reset()
 
-        decisionService = DefaultDecisionService(bucketer: DefaultBucketer(), userProfileService: ups)
+        decisionService = DefaultDecisionService(userProfileService: ups)
     }
 
     func testSave() {