(feat): SwiftLint added. (#210)

* Swift Linter added.

* Fixed recommended changes by linter.

* Podfile updated

* update project to use pod

* added SwiftLint to README credits

Author: yasirfolio3

DemoSwiftApp/AppDelegate.swift

@@ -17,7 +17,6 @@
 import UIKit
 import Optimizely
 
-
 @UIApplicationMain
 class AppDelegate: UIResponder, UIApplicationDelegate {
     let logLevel = OptimizelyLogLevel.debug
@@ -26,10 +25,10 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
     let datafileName = "demoTestDatafile"
     let experimentKey = "background_experiment"
     let eventKey = "sample_conversion"
-    
+
     let userId = String(Int.random(in: 0..<100000))
-    let attributes: [String : Any?] = ["browser_type": "safari", "bool_attr": false]
-    
+    let attributes: [String: Any?] = ["browser_type": "safari", "bool_attr": false]
+
     var window: UIWindow?
     var optimizely: OptimizelyClient!
     var storyboard: UIStoryboard {
@@ -39,7 +38,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
         return UIStoryboard(name: "tvOSMain", bundle: nil)
         #endif
     }
-    
+
     func applicationDidFinishLaunching(_ application: UIApplication) {
 
         // initialize SDK in one of these two ways:
@@ -52,9 +51,9 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
 
         initializeOptimizelySDKWithCustomization()
     }
-    
+
     // MARK: - Initialization Examples
-    
+
     func initializeOptimizelySDKAsynchronous() {
         optimizely = OptimizelyClient(sdkKey: sdkKey, defaultLogLevel: logLevel)
 
@@ -67,16 +66,16 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
             case .success:
                 print("Optimizely SDK initialized successfully!")
             }
-            
+
             self.startWithRootViewController()
         }
     }
-    
+
     func initializeOptimizelySDKSynchronous() {
         guard let localDatafilePath = Bundle.main.path(forResource: datafileName, ofType: "json") else {
             fatalError("Local datafile cannot be found")
         }
-        
+
         optimizely = OptimizelyClient(sdkKey: sdkKey, defaultLogLevel: logLevel)
 
         addListeners()
@@ -89,24 +88,23 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
         } catch {
             print("Optimizely SDK initiliazation failed: \(error)")
         }
-        
+
         startWithRootViewController()
     }
-    
+
     func initializeOptimizelySDKWithCustomization() {
         // customization example (optional)
-        
+
         let customLogger = CustomLogger()
         // 30 sec interval may be too frequent. This is for demo purpose.
         // This should be should be much larger (default = 10 mins).
         let customDownloadIntervalInSecs = 30
-        
+
         optimizely = OptimizelyClient(sdkKey: sdkKey,
                                        logger: customLogger,
                                        periodicDownloadInterval: customDownloadIntervalInSecs,
                                        defaultLogLevel: logLevel)
-        
-
+    
         addListeners()
 
         // initialize SDK
@@ -123,16 +121,16 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
 
     func addListeners() {
         // notification listeners
-        
+
         _ = optimizely.notificationCenter.addDecisionNotificationListener(decisionListener: { (type, userId, attributes, decisionInfo) in
             print("Received decision notification: \(type) \(userId) \(String(describing: attributes)) \(decisionInfo)")
         })
 
         _ = optimizely.notificationCenter.addTrackNotificationListener(trackListener: { (eventKey, userId, attributes, eventTags, event) in
             print("Received track notification: \(eventKey) \(userId) \(String(describing: attributes)) \(String(describing: eventTags)) \(event)")
         })
-        
-        _ = optimizely.notificationCenter.addDatafileChangeNotificationListener(datafileListener: { (data) in
+
+        _ = optimizely.notificationCenter.addDatafileChangeNotificationListener(datafileListener: { (_) in
             DispatchQueue.main.async {
                 #if os(iOS)
                 if let controller = self.window?.rootViewController {
@@ -143,23 +141,24 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
                 #else
                 print("Datafile changed")
                 #endif
-                
+
                 if let controller = self.window?.rootViewController as? VariationViewController {
                     //controller.showCoupon = toggle == FeatureFlagToggle.on ? true : false;
                     controller.showCoupon = self.optimizely.isFeatureEnabled(featureKey: "show_coupon",
                                                                              userId: self.userId)
                 }
             }
         })
+
     }
 
     // MARK: - ViewControl
-    
+
     func startWithRootViewController() {
         DispatchQueue.main.async {
             do {
                 // For sample codes for other APIs, see "Samples/SamplesForAPI.swift"
-                
+
                 let variationKey = try self.optimizely.activate(experimentKey: self.experimentKey,
                                                            userId: self.userId,
                                                            attributes: self.attributes)
@@ -173,10 +172,10 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
             }
         }
     }
-    
+
     func openVariationView(variationKey: String?) {
         let variationViewController = storyboard.instantiateViewController(withIdentifier: "VariationViewController") as! VariationViewController
-        
+
         variationViewController.showCoupon = optimizely.isFeatureEnabled(featureKey: "show_coupon",
                                                                          userId: userId)
         variationViewController.optimizely = optimizely
@@ -190,29 +189,28 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
     func openFailureView() {
         window?.rootViewController = storyboard.instantiateViewController(withIdentifier: "FailureViewController")
     }
-    
+
     // MARK: - AppDelegate
-    
+
     func applicationWillResignActive(_ application: UIApplication) {
     }
-    
+
     func applicationDidEnterBackground(_ application: UIApplication) {
     }
-    
+
     func applicationWillEnterForeground(_ application: UIApplication) {
     }
-    
+
     func applicationDidBecomeActive(_ application: UIApplication) {
     }
-    
+
     func applicationWillTerminate(_ application: UIApplication) {
     }
-    
+
     func application(_ application: UIApplication, performFetchWithCompletionHandler completionHandler: (UIBackgroundFetchResult) -> Void) {
-        
+
         // add background fetch task here
-        
+
         completionHandler(.newData)
     }
 }
-

DemoSwiftApp/Customization/CustomLogger.swift

@@ -21,4 +21,3 @@ class CustomLogger: OPTLogger {
         }
     }
 }
-

DemoSwiftApp/Samples/SamplesForAPI.swift

@@ -15,26 +15,25 @@
  * limitations under the License.                                           *
  ***************************************************************************/
 
-
 import Foundation
 import Optimizely
 
 class SamplesForAPI {
-    
+
     static func run(optimizely: OptimizelyClient) {
-        
+
         let attributes: [String: Any] = [
             "device": "iPhone",
             "lifetime": 24738388,
-            "is_logged_in": true,
+            "is_logged_in": true
             ]
         let tags: [String: Any] = [
             "category": "shoes",
-            "count": 2,
+            "count": 2
             ]
-        
+
         // MARK: - activate
-        
+
         do {
             let variationKey = try optimizely.activate(experimentKey: "my_experiment_key",
                                                        userId: "user_123",
@@ -43,9 +42,9 @@ class SamplesForAPI {
         } catch {
             print(error)
         }
-        
+
         // MARK: - getVariationKey
-        
+
         do {
             let variationKey = try optimizely.getVariationKey(experimentKey: "my_experiment_key",
                                                               userId: "user_123",
@@ -54,28 +53,28 @@ class SamplesForAPI {
         } catch {
             print(error)
         }
-        
+
         // MARK: - getForcedVariation
-        
+
         if let variationKey = optimizely.getForcedVariation(experimentKey: "my_experiment_key", userId: "user_123") {
             print("[getForcedVariation] \(variationKey)")
         }
-        
+
         // MARK: - setForcedVariation
 
         if optimizely.setForcedVariation(experimentKey: "my_experiment_key",
                                          userId: "user_123",
                                          variationKey: "some_variation_key") {
             print("[setForcedVariation]")
         }
-        
+
         // MARK: - isFeatureEnabled
 
         let enabled = optimizely.isFeatureEnabled(featureKey: "my_feature_key",
                                                           userId: "user_123",
                                                           attributes: attributes)
         print("[isFeatureEnabled] \(enabled)")
-        
+
         // MARK: - getFeatureVariable
 
         do {
@@ -87,12 +86,12 @@ class SamplesForAPI {
         } catch {
             print(error)
         }
-        
+
         // MARK: - getEnabledFeatures
 
         let enabledFeatures = optimizely.getEnabledFeatures(userId: "user_123", attributes: attributes)
         print("[getEnabledFeatures] \(enabledFeatures)")
-        
+
         // MARK: - track
 
         do {
@@ -102,6 +101,5 @@ class SamplesForAPI {
             print(error)
         }
     }
-    
-    
+
 }

DemoSwiftApp/SharedResources/DemoSwifttvOS/Assets.xcassets/LaunchImage-2.launchimage/Contents.json

@@ -18,31 +18,31 @@ import UIKit
 import Optimizely
 
 class VariationViewController: UIViewController {
-    
+
     var eventKey: String!
     var userId: String!
     var variationKey: String?
     var optimizely: OptimizelyClient?
     var showCoupon: Bool = false {
-        didSet  {
+        didSet {
             DispatchQueue.main.async {
                 self.couponView?.isHidden = !self.showCoupon
             }
         }
     }
 
-    @IBOutlet weak var couponView:UIView!
+    @IBOutlet weak var couponView: UIView!
     @IBOutlet weak var variationLetterLabel: UILabel!
     @IBOutlet weak var variationSubheaderLabel: UILabel!
     @IBOutlet weak var variationBackgroundImage: UIImageView!
-    
+
     @IBAction func closeCoupon(_ sender: UIButton) {
         showCoupon = false
     }
-    
+
     @IBAction func unwindToVariationAction(unwindSegue: UIStoryboardSegue) {
     }
-    
+
     @IBAction func attemptTrackAndShowSuccessOrFailure(_ sender: Any) {
         do {
             try self.optimizely?.track(eventKey: self.eventKey, userId: userId)
@@ -54,7 +54,7 @@ class VariationViewController: UIViewController {
 
     override func viewDidLoad() {
         super.viewDidLoad()
-        
+
         if let variationKey = self.variationKey {
             switch variationKey {
             case "variation_a":