clean up: fix test cases

Author: muzahidul-opti

Tests/OptimizelyTests-DataModel/HoldoutTests.swift

@@ -100,7 +100,7 @@ extension HoldoutTests {
         XCTAssertEqual(model.includedFlags, ["4444", "5555"])
     }
 
-    func testDecodeSuccessWithIncludedAndExcludedFlags() {
+    func testDecodeSuccessWithExcludedFlags() {
         let data: [String: Any] = HoldoutTests.sampleDataWithExcludedFlags
 
         let model: Holdout = try! OTUtils.model(from: data)
@@ -113,7 +113,7 @@ extension HoldoutTests {
         XCTAssert(model.trafficAllocation == [try! OTUtils.model(from: HoldoutTests.trafficAllocationData)])
         XCTAssert(model.audienceIds == ["33333"])
         XCTAssert(model.audienceConditions == (try! OTUtils.model(from: HoldoutTests.conditionHolderData)))
-        XCTAssertEqual(model.includedFlags, ["4444", "5555"])
+        XCTAssertEqual(model.includedFlags, [])
         XCTAssertEqual(model.excludedFlags, ["8888", "9999"])
     }
 

Tests/OptimizelyTests-DataModel/ProjectConfigTests.swift

@@ -160,8 +160,8 @@ class ProjectConfigTests: XCTestCase {
 
         /// Test Global holdout + included
 
-        XCTAssertEqual(projectConfig.holdoutConfig.getHoldoutForFlag(id: "2000").map { $0.id }, ["3000", "3001", "3002", "3003"])
-        XCTAssertEqual(projectConfig.holdoutConfig.getHoldoutForFlag(id: "2002").map { $0.id }, ["3000", "3001", "3002", "3003"])
+        XCTAssertEqual(projectConfig.holdoutConfig.getHoldoutForFlag(id: "2000").map { $0.id }, ["3000", "3001", "3002", "3004", "3003"])
+        XCTAssertEqual(projectConfig.holdoutConfig.getHoldoutForFlag(id: "2002").map { $0.id }, ["3000", "3001", "3002", "3004","3003"])
 
         /// Test Global holdout - excluded
         XCTAssertEqual(projectConfig.holdoutConfig.getHoldoutForFlag(id: "2001").map { $0.id }, ["3000", "3001", "3002"])