Skip to content

Commit 95bb25b

Browse files
committed
fix tests for changing to start
1 parent 425af11 commit 95bb25b

File tree

9 files changed

+23
-23
lines changed

9 files changed

+23
-23
lines changed

OptimizelySDK/OptimizelyTests/OptimizelyTests-APIs/OptimizelyManagerTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class OptimizelyManagerTests: XCTestCase {
2525
// Put setup code here. This method is called before the invocation of each test method in the class.
2626
optimizely = OptimizelyManager(sdkKey: "SDKKEY")
2727

28-
try! optimizely?.initializeSDK(datafile:json)
28+
try! optimizely?.start(datafile:json)
2929
}
3030

3131
override func tearDown() {

OptimizelySDK/OptimizelyTests/OptimizelyTests-APIs/OptimizelyManagerTests_ForcedVariation.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class OptimizelyManagerTests_ForcedVariation: XCTestCase {
3333

3434
self.optimizely = OptimizelyManager(sdkKey: "12345",
3535
userProfileService: OTUtils.createClearUserProfileService())
36-
try! self.optimizely.initializeSDK(datafile: datafile)
36+
try! self.optimizely.start(datafile: datafile)
3737
}
3838

3939
func testForcedVariation_ThenActivate() {
@@ -79,7 +79,7 @@ class OptimizelyManagerTests_ForcedVariation: XCTestCase {
7979

8080
// reload ProjectConfig (whitelist must NOT be sustained)
8181

82-
try! self.optimizely.initializeSDK(datafile: datafile)
82+
try! self.optimizely.start(datafile: datafile)
8383
variationKey = self.optimizely.getForcedVariation(experimentKey: kExperimentKey, userId: kUserId)
8484
XCTAssertNil(variationKey)
8585
}

OptimizelySDK/OptimizelyTests/OptimizelyTests-APIs/OptimizelyManagerTests_Invalid.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class OptimizelyManagerTests_Invalid: XCTestCase {
3333
self.optimizely = OptimizelyManager(sdkKey: kSdkKey)
3434

3535
let invalidDatafile = "{\"version\": \"4\"}"
36-
try? self.optimizely.initializeSDK(datafile: invalidDatafile)
36+
try? self.optimizely.start(datafile: invalidDatafile)
3737
}
3838

3939
func testActivate_WhenManagerNonInitialized() {

OptimizelySDK/OptimizelyTests/OptimizelyTests-APIs/OptimizelyManagerTests_ObjcAPIs.m

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -51,20 +51,19 @@ @interface OptimizelyManagerTests_ObjcAPIs : XCTestCase
5151
// MARK: - Customization Modules Protocols
5252

5353
@interface TestOPTLogger: NSObject <OPTLogger>
54-
@property(nonatomic, assign) OptimizelyLogLevel logLevel;
5554
@end
5655

5756
@implementation TestOPTLogger
58-
+ (enum OptimizelyLogLevel)logLevel {
59-
return OptimizelyLogLevelInfo;
60-
}
61-
6257
- (void)logWithLevel:(enum OptimizelyLogLevel)level message:(NSString * _Nonnull)message {
6358
NSLog(@"[LOG] %@", message);
6459
}
6560

61+
static enum OptimizelyLogLevel logLevel = OptimizelyLogLevelInfo;
62+
+ (enum OptimizelyLogLevel)logLevel {
63+
return logLevel;
64+
}
6665
+ (void)setLogLevel:(enum OptimizelyLogLevel)newValue {
67-
self.logLevel = newValue;
66+
logLevel = newValue;
6867
}
6968
@end
7069

@@ -95,7 +94,7 @@ - (void)saveWithUserProfile:(NSDictionary<NSString *,id> * _Nonnull)userProfile
9594
@end
9695

9796

98-
// AMRK: - tests
97+
// MARK: - tests
9998

10099
@implementation OptimizelyManagerTests_ObjcAPIs
101100

@@ -105,7 +104,7 @@ - (void)setUp {
105104

106105
self.optimizely = [[OptimizelyManager alloc] initWithSdkKey: kSdkKey];
107106

108-
[self.optimizely initializeSDKWithDatafile:fileContents error:nil];
107+
[self.optimizely startWithDatafile:fileContents error:nil];
109108

110109
self.attributes = @{ @"name": @"tom", @"age": @21 };
111110
}
@@ -229,13 +228,14 @@ - (void)testCustomizationAPIs {
229228
logger:logger
230229
eventDispatcher:eventDispatcher
231230
userProfileService:userProfileService
232-
periodicDownloadInterval:@(50)];
231+
periodicDownloadInterval:@(50)
232+
defaultLogLevel:OptimizelyLogLevelInfo];
233233

234-
[self.optimizely initializeSDKWithCompletion:^(NSData * _Nullable data, NSError * _Nullable error) {}];
234+
[self.optimizely startWithCompletion:^(NSData * _Nullable data, NSError * _Nullable error) {}];
235235

236-
[self.optimizely initializeSDKWithDatafile:datafile error:nil];
236+
[self.optimizely startWithDatafile:datafile error:nil];
237237

238-
[self.optimizely initializeSDKWithDatafile:datafileData doFetchDatafileBackground:false error:nil];
238+
[self.optimizely startWithDatafile:datafileData doFetchDatafileBackground:false error:nil];
239239
}
240240

241241
@end

OptimizelySDK/OptimizelyTests/OptimizelyTests-APIs/OptimizelyManagerTests_Valid.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ class OptimizelyManagerTests_Valid: XCTestCase {
5656

5757
self.optimizely = OptimizelyManager(sdkKey: "12345",
5858
userProfileService: OTUtils.createClearUserProfileService())
59-
try! self.optimizely.initializeSDK(datafile: datafile)
59+
try! self.optimizely.start(datafile: datafile)
6060
}
6161

6262
func testActivate() {

OptimizelySDK/OptimizelyTests/OptimizelyTests-Common/BatchEventBuilderTest.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class BatchEventBuilderTests: XCTestCase {
3030

3131
let datafile = OTUtils.loadJSONDatafile(datafileName)
3232
do {
33-
try optimizely?.initializeSDK(datafile: datafile!)
33+
try optimizely?.start(datafile: datafile!)
3434
}
3535
catch {
3636
print(error)

OptimizelySDK/OptimizelyTests/OptimizelyTests-Common/DecisionListenerTests.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class DecisionListenerTests: XCTestCase {
4949

5050
self.optimizely = FakeManager(sdkKey: "12345",
5151
userProfileService: OTUtils.createClearUserProfileService())
52-
try! self.optimizely.initializeSDK(datafile: datafile)
52+
try! self.optimizely.start(datafile: datafile)
5353

5454

5555
self.optimizely2 = OTUtils.createOptimizely(datafileName: "audience_targeting", clearUserProfileService: true)
@@ -571,9 +571,9 @@ class FakeManager: OptimizelyManager {
571571
}
572572
}
573573

574-
override init(sdkKey: String, logger:OPTLogger? = nil, eventDispatcher:OPTEventDispatcher? = nil, userProfileService:OPTUserProfileService? = nil, periodicDownloadInterval:Int? = nil) {
574+
override init(sdkKey: String, logger:OPTLogger? = nil, eventDispatcher:OPTEventDispatcher? = nil, userProfileService:OPTUserProfileService? = nil, periodicDownloadInterval:Int? = nil, defaultLogLevel: OptimizelyLogLevel? = nil) {
575575

576-
super.init(sdkKey: sdkKey, logger: logger, eventDispatcher: eventDispatcher, userProfileService: userProfileService, periodicDownloadInterval: periodicDownloadInterval)
576+
super.init(sdkKey: sdkKey, logger: logger, eventDispatcher: eventDispatcher, userProfileService: userProfileService, periodicDownloadInterval: periodicDownloadInterval, defaultLogLevel: defaultLogLevel)
577577
HandlerRegistryService.shared.removeAll()
578578

579579
let userProfileService = userProfileService ?? DefaultUserProfileService()

OptimizelySDK/OptimizelyTests/OptimizelyTests-DataModel/AudienceTests_Evaluate.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ class AudienceTests_Evaluate: XCTestCase {
6161
self.typedAudienceDatafile = OTUtils.loadJSONDatafile("typed_audience_datafile")
6262

6363
self.optimizely = OptimizelyManager(sdkKey: "12345")
64-
try! self.optimizely.initializeSDK(datafile: typedAudienceDatafile)
64+
try! self.optimizely.start(datafile: typedAudienceDatafile)
6565
}
6666

6767

OptimizelySDK/OptimizelyTests/TestUtils/OTUtils.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class OTUtils {
8383
eventDispatcher: eventDispatcher,
8484
userProfileService: userProfileService)
8585
do {
86-
try optimizely.initializeSDK(datafile: datafile, doFetchDatafileBackground: false)
86+
try optimizely.start(datafile: datafile, doFetchDatafileBackground: false)
8787
return optimizely
8888
} catch {
8989
return nil

0 commit comments

Comments
 (0)