Merge pull request #120 from optimizely/fixConcurrentTest

jaeopt · web-flow · commit 8e7eb23cad80 · 2019-03-27T09:03:14.000-07:00
(fix): since it was using async and i was not using a sync after, the queue …
diff --git a/OptimizelySDK/OptimizelyTests/OptimizelyTests-APIs/OptimizelyManagerTests_Threading.swift b/OptimizelySDK/OptimizelyTests/OptimizelyTests-APIs/OptimizelyManagerTests_Threading.swift
@@ -270,7 +270,7 @@ class OptimizelyManagerTests_Threading: XCTestCase {
                 let enabled = try? optimizely2.isFeatureEnabled(featureKey: "feat", userId: self.userId, attributes: ["house": "Gryffindor"])
                 let variation = try? optimizely3.activate(experimentKey: "ab_running_exp_untargeted", userId: self.userId)
                 
-                appendLock.async {
+                appendLock.sync {
                     atomicBackground.property!.append((enabled: enabled!, variation: variation!))
                 }
                 

Original file line number	Diff line number	Diff line change
`@@ -270,7 +270,7 @@ class OptimizelyManagerTests_Threading: XCTestCase {`
`270`	`270`	`let enabled = try? optimizely2.isFeatureEnabled(featureKey: "feat", userId: self.userId, attributes: ["house": "Gryffindor"])`
`271`	`271`	`let variation = try? optimizely3.activate(experimentKey: "ab_running_exp_untargeted", userId: self.userId)`
`272`	`272`
`273`		`- appendLock.async {`
	`273`	`+ appendLock.sync {`
`274`	`274`	`atomicBackground.property!.append((enabled: enabled!, variation: variation!))`
`275`	`275`	`}`
`276`	`276`