chore: update unit tests settings for github actions (#463)

Author: jaeopt

.github/workflows/swift.yml

@@ -37,7 +37,7 @@ jobs:
     - uses: actions/checkout@v3
     - uses: maxim-lobanov/setup-xcode@v1
       with:
-        xcode-version: '12.4'
+        xcode-version: 12.4
     - env:
         SRCCLR_API_TOKEN: ${{ secrets.SRCCLR_API_TOKEN }}
       run: |
@@ -47,7 +47,10 @@ jobs:
 
   unittests: 
     if: "${{ github.event.inputs.PREP == '' && github.event.inputs.RELEASE == '' }}" 
-    uses: optimizely/swift-sdk/.github/workflows/unit_tests.yml@master
+
+    #[TODO]: change to @master again
+    #uses: optimizely/swift-sdk/.github/workflows/unit_tests.yml@master
+    uses: optimizely/swift-sdk/.github/workflows/unit_tests.yml@jae/version-update
 
   prepare_for_release:
     runs-on: macos-latest
@@ -56,7 +59,7 @@ jobs:
     - uses: actions/checkout@v3
     - uses: maxim-lobanov/setup-xcode@v1
       with:
-        xcode-version: '12.4'
+        xcode-version: 12.4
     - id: prepare_for_release
       name: Prepare for release
       env:
@@ -79,7 +82,7 @@ jobs:
     - uses: actions/checkout@v3
     - uses: maxim-lobanov/setup-xcode@v1
       with:
-        xcode-version: '12.4'
+        xcode-version: 12.4
     - name: Push to cocoapods.org
       env:
         GITHUB_TOKEN: ${{ secrets.CI_USER_TOKEN }}

.github/workflows/unit_tests.yml

@@ -11,35 +11,41 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
+        # github actions are very poor in supporting iOS simulators:
+        # - multiple Xcode versions are pre installed (not all versions and they change supported xcode versions frequently)
+        # - each xcode version has own simulator os versions.
+        # - so to run tests with the target simulator, we have to find a proper xcode version pre-installed and support the target simulator os version.
+        #   also, the xcode version (simulator_xcode_version) and simulator os versions (os) are moving target. We have to change these time to time.
         include:
-          - os: 14.4
+          - os: 15.2
             device: "iPhone 11"
             scheme: "OptimizelySwiftSDK-iOS"
             test_sdk: "iphonesimulator"
             platform: "iOS Simulator"
             os_type: "iOS"
-            simulator_xcode_version: 12.4
-          - os: 13.3
+            simulator_xcode_version: 13.2
+          - os: 14.4
             device: "iPhone 8"
             scheme: "OptimizelySwiftSDK-iOS"
             test_sdk: "iphonesimulator"
             platform: "iOS Simulator"
             os_type: "iOS"
-            simulator_xcode_version: 11.3.1
-          - os: 12.4
-            device: "iPad Air"
+            simulator_xcode_version: 12.4
+          - os: 13.7
+            # good to have tests with older OS versions, but it looks like this is min OS+xcode versions supported by github actions
+            device: "iPad Air (3rd generation)"
             scheme: "OptimizelySwiftSDK-iOS"
             test_sdk: "iphonesimulator"
             platform: "iOS Simulator"
             os_type: "iOS"
-            simulator_xcode_version: 10.3
-          - os: 12.4
+            simulator_xcode_version: 11.7
+          - os: 13.4
             device: "Apple TV 4K"
             scheme: "OptimizelySwiftSDK-tvOS"
             test_sdk: "appletvsimulator"
             platform: "tvOS Simulator"
             os_type: "tvOS"
-            simulator_xcode_version: 10.3
+            simulator_xcode_version: 11.7
     steps:
       - uses: actions/checkout@v3
       - uses: maxim-lobanov/setup-xcode@v1
@@ -68,6 +74,16 @@ jobs:
           pod repo update
           pod install
           HOMEBREW_NO_INSTALL_CLEANUP=true brew update && brew install jq
+
+          # github actions are very poor in supporting iOS simulators:
+          # - to find pre-installed xcode version, run this:
+          # > ls /Applications/
+          # - to find supported simulator os versions, run this (and find simulator with non-error "datapath")
+          # > xcrun simctl list --json devices
+
+          # switch to the target xcode version
+          sudo xcode-select -switch /Applications/Xcode_$SIMULATOR_XCODE_VERSION.app
+
           Scripts/prepare_simulator.sh
           Scripts/run_unit_tests.sh
       - name: Check on failures (Archive Test Results)

Scripts/prepare_simulator.sh

@@ -12,10 +12,12 @@ set -eou pipefail
 # More about XCode and its compatible simulators can be found here: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md
 # https://github.com/actions/virtual-environments/issues/551
 
-if [ "$SIMULATOR_XCODE_VERSION" != 12.4 ]; then
+# Older than Xcode 12 (12.4?) has different paths
+MAJOR_SIMULATOR_XCODE_VERSION=$(echo $SIMULATOR_XCODE_VERSION | cut -d. -f1)
+if [ "$MAJOR_SIMULATOR_XCODE_VERSION" -lt 12 ]; then
     os_folder="iPhoneOS"
     os="${OS/./-}"
-    name="${NAME// /-}"
+    name="${NAME//[ ()]/-}"
 
     sudo mkdir -p /Library/Developer/CoreSimulator/Profiles/Runtimes