add tests for blanks as invalid (#351)

Author: thomaszurkan-optimizely

Sources/Data Model/Audience/SemanticVersion.swift

@@ -64,6 +64,10 @@ extension SemanticVersion {
         var targetPrefix = self
         var targetSuffix:ArraySlice<Substring>?
 
+        if hasWhiteSpace {
+            throw OptimizelyError.attributeFormatInvalid
+        }
+        
         if isPreRelease || isBuild {
             targetParts = split(separator: isPreRelease ? preReleaseSeperator : buildSeperator)
             guard let targetParts = targetParts, targetParts.count > 1 else {
@@ -83,6 +87,10 @@ extension SemanticVersion {
         }
         return targetedVersionParts
     }
+    
+    var hasWhiteSpace: Bool {
+        return contains(" ")
+    }
 
     var isNumber: Bool {
         return !isEmpty && rangeOfCharacter(from: CharacterSet.decimalDigits.inverted) == nil

Tests/OptimizelyTests-DataModel/SemanticVersionTests.swift

@@ -165,7 +165,7 @@ class SemanticVersionTests: XCTestCase {
 
     func testInvalidAttributes() {
         let target = "2.1.0"
-        let versions = ["-", ".", "..", "+", "+test"]
+        let versions = ["-", ".", "..", "+", "+test", " ", "2 .3. 0"]
         for (_, version) in versions.enumerated() {
             XCTAssert(((try? (version.compareVersion(targetedVersion: target)) < 0) == nil))
         }