Client initialize event sperated from odp manager

Author: muzahidul-opti

Sources/ODP/OdpManager.swift

@@ -61,9 +61,6 @@ public class OdpManager {
         self.odpConfig = OdpConfig()
         self.segmentManager.odpConfig = odpConfig
         self.eventManager.odpConfig = odpConfig
-        if let vuid = vuid, VuidManager.isVuid(vuid) {
-            self.eventManager.sendInitializedEvent(vuid: vuid)
-        }
     }
 
     func fetchQualifiedSegments(userId: String,

Sources/Optimizely/OptimizelyClient.swift

@@ -96,12 +96,11 @@ open class OptimizelyClient: NSObject {
         self.vuidManager.configure(enable: self.sdkSettings.enableVuid)
         self.odpManager = odpManager ?? OdpManager(sdkKey: sdkKey,
                                                    disable: sdkSettings.disableOdp,
-                                                   vuid: vuidManager.vuid,
                                                    cacheSize: sdkSettings.segmentsCacheSize,
                                                    cacheTimeoutInSecs: sdkSettings.segmentsCacheTimeoutInSecs,
                                                    timeoutForSegmentFetchInSecs: sdkSettings.timeoutForSegmentFetchInSecs,
                                                    timeoutForEventDispatchInSecs: sdkSettings.timeoutForOdpEventInSecs)
-
+        self.odpManager.vuid = vuidManager.vuid
         let userProfileService = userProfileService ?? DefaultUserProfileService()
         let logger = logger ?? DefaultLogger()
         type(of: logger).logLevel = defaultLogLevel ?? .info
@@ -119,6 +118,16 @@ open class OptimizelyClient: NSObject {
         self.decisionService = HandlerRegistryService.shared.injectDecisionService(sdkKey: self.sdkKey)
         self.notificationCenter = HandlerRegistryService.shared.injectNotificationCenter(sdkKey: self.sdkKey)
 
+        if let _vuid = self.vuidManager.vuid {
+            try? sendOdpEvent(type: Constants.ODP.eventType,
+                              action: "client_initialized",
+                              identifiers: [
+                                Constants.ODP.keyForVuid: _vuid
+                              ],
+                              data: [:])
+        }
+
+        
         logger.d("SDK Version: \(version)")
     }
 

Tests/OptimizelyTests-Common/OptimizelyUserContextTests_ODP_2.swift

@@ -26,21 +26,31 @@ class OptimizelyUserContextTests_ODP_2: XCTestCase {
 
         // odp disabled to avoid initial noise
 
-        let optimizely = OptimizelyClient(sdkKey: sdkKey,
-                                          settings: OptimizelySdkSettings(disableOdp: true, enableVuid: true))
-        
+//        let optimizely = OptimizelyClient(sdkKey: sdkKey,
+//                                          settings: OptimizelySdkSettings(disableOdp: true, enableVuid: true))
+//        
         // override with a custom enabled odpManager.
         // - client_inializatied event will be sent automatically
         // - will wait in the queue until project config is ready
 
         let odpEventApiManager = MockOdpEventApiManager()
-        optimizely.odpManager = OdpManager(sdkKey: sdkKey,
-                                    disable: false,
-                                    vuid: "vuid_123",
-                                    cacheSize: 10,
-                                    cacheTimeoutInSecs: 10,
-                                    eventManager: OdpEventManager(sdkKey: sdkKey,
-                                                                  apiManager: odpEventApiManager))
+        
+        let optimizely = OptimizelyClient(sdkKey: sdkKey,
+                                          odpManager:
+                                            OdpManager(sdkKey: sdkKey,
+                                                       disable: false,
+                                                       vuid: "vuid_123",
+                                                       cacheSize: 10,
+                                                       cacheTimeoutInSecs: 10,
+                                                       eventManager:
+                                                        OdpEventManager(
+                                                            sdkKey: sdkKey,
+                                                            apiManager: odpEventApiManager
+                                                        )
+                                                      ),
+                                          settings:
+                                            OptimizelySdkSettings(disableOdp: true, enableVuid: true)
+        )
 
         // identified event will sent but wait in the queue until project config is ready
         _ = optimizely.createUserContext(userId: "tester")