Add Swift Package Manager (SPM) support (#243)

* (wip) restructure for SPM

* cleanup

* restructure for SPM support

* clean up

* fix SPM source path

* fix podspec for new SPM paths

* remove header files from podspec

* move swiftlint trigger to DemoApp to isolate it from Carthage package

* add xcshareddata for schemes

* add SPM instruction to README

* fix Podfile error

* fix project path for slather/coveralls

* fix workspace path for travis

* fix workspace path for slather/coveralls

* turn off coverage for tvOS (iOS can be used for coverall)

* fix per review

Author: jaeopt

.gitignore

@@ -35,6 +35,7 @@ xcuserdata/
 build
 *.xcodeproj/*
 !*.xcodeproj/project.pbxproj
+!*.xcodeproj/xcshareddata/
 !*.xcworkspace/contents.xcworkspacedata
 
 # CocoaPods
@@ -52,6 +53,12 @@ Pods/
 
 Carthage/Build
 
+# SPM
+
+.build
+.swiftpm
+Packages
+
 # fastlane
 #
 # It is recommended to not store the screenshots in the git repo. Instead, use fastlane to re-generate the 

.slather.yml

@@ -1,5 +1,5 @@
 coverage_service: coveralls
-xcodeproj: OptimizelySDK/OptimizelySwiftSDK.xcodeproj
+xcodeproj: OptimizelySwiftSDK.xcodeproj
 scheme: OptimizelySwiftSDK-iOS
-workspace: OptimizelySDK.xcworkspace
+workspace: OptimizelySwiftSDK.xcworkspace
 configuration: Release

OptimizelySDK/.swiftlint.yml renamed to .swiftlint.yml

@@ -10,7 +10,7 @@ excluded:
 - Carthage
 - Pods
 - SwiftLint/Common/3rdPartyLib
-- OptimizelyTests
+- Tests
 line_length:
     warning: 350
     error: 400

OptimizelySDK/OptimizelySwiftSDK.xcodeproj/project.xcworkspace/contents.xcworkspacedata renamed to .swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata

@@ -59,7 +59,7 @@ jobs:
         # preload simulator
         - Scripts/start_simulator.sh
       script:
-        - if [[ "$TRAVIS_BRANCH" == "master" ]]; then xcodebuild test -workspace OptimizelySDK.xcworkspace -scheme $SCHEME -configuration Release CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO -sdk $TEST_SDK -destination "platform=$PLATFORM,OS=$OS,name=$NAME" ONLY_ACTIVE_ARCH=YES > buildoutput; cat buildoutput | xcpretty; fi
+        - if [[ "$TRAVIS_BRANCH" == "master" ]]; then xcodebuild test -workspace OptimizelySwiftSDK.xcworkspace -scheme $SCHEME -configuration Release CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO -sdk $TEST_SDK -destination "platform=$PLATFORM,OS=$OS,name=$NAME" ONLY_ACTIVE_ARCH=YES > buildoutput; cat buildoutput | xcpretty; fi
       after_success:
         - slather
         - sleep 5 # https://github.com/travis-ci/travis-ci/issues/4725

OptimizelySDK.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist renamed to .swiftpm/xcode/package.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist

@@ -174,16 +174,18 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
     }
 
     func openVariationView(variationKey: String?) {
-        let variationViewController = storyboard.instantiateViewController(withIdentifier: "VariationViewController") as! VariationViewController
+        if let variationViewController = storyboard.instantiateViewController(withIdentifier: "VariationViewController")
+            as? VariationViewController {
 
-        variationViewController.showCoupon = optimizely.isFeatureEnabled(featureKey: "show_coupon",
+            variationViewController.showCoupon = optimizely.isFeatureEnabled(featureKey: "show_coupon",
                                                                          userId: userId)
-        variationViewController.optimizely = optimizely
-        variationViewController.userId = userId
-        variationViewController.variationKey = variationKey
-        variationViewController.eventKey = eventKey
+            variationViewController.optimizely = optimizely
+            variationViewController.userId = userId
+            variationViewController.variationKey = variationKey
+            variationViewController.eventKey = eventKey
 
-        window?.rootViewController = variationViewController
+            window?.rootViewController = variationViewController
+        }
     }
 
     func openFailureView() {
@@ -207,7 +209,8 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
     func applicationWillTerminate(_ application: UIApplication) {
     }
 
-    func application(_ application: UIApplication, performFetchWithCompletionHandler completionHandler: (UIBackgroundFetchResult) -> Void) {
+    func application(_ application: UIApplication,
+                     performFetchWithCompletionHandler completionHandler: (UIBackgroundFetchResult) -> Void) {
 
         // add background fetch task here
 

.travis.yml

@@ -2,8 +2,8 @@ Pod::Spec.new do |s|
   s.name                    = "OptimizelySwiftSDK"
   s.module_name	            = "Optimizely"
   s.version                 = "3.1.0-beta"
-  s.summary                 = "Optimizely server-side testing core framework."
-  s.homepage                = "http://developers.optimizely.com/server/reference/index.html?language=objectivec"
+  s.summary                 = "Optimizely experiment framework for iOS/tvOS"
+  s.homepage                = "https://docs.developers.optimizely.com/full-stack/docs"
   s.license                 = { :type => "Apache License, Version 2.0", :file => "LICENSE" }
   s.author                  = { "Optimizely" => "support@optimizely.com" }
   s.ios.deployment_target   = "9.0"
@@ -12,10 +12,8 @@ Pod::Spec.new do |s|
     :git => "https://github.com/optimizely/swift-sdk.git",
     :tag => "v"+s.version.to_s
   }
-  s.source_files            = "OptimizelySDK/**/*.{swift,h}"
-  s.public_header_files     = "OptimizelySDK/OptimizelySwiftSDK/*.h"
-  s.exclude_files           = "OptimizelySDK/Optimizely*Tests/**/*"
-  s.swift_version           = "4.2"
+  s.source_files            = "Sources/**/*.swift"
+  s.swift_version           = "5.0"
   s.framework               = "Foundation"
   s.requires_arc            = true
   s.xcconfig                = { 'GCC_PREPROCESSOR_DEFINITIONS' => "OPTIMIZELY_SDK_VERSION=@\\\"#{s.version}\\\"" }